Update membership-check.php to include timezone check#672
Merged
mauteri merged 6 commits intoGatherPress:mainfrom Jun 5, 2024
Merged
Update membership-check.php to include timezone check#672mauteri merged 6 commits intoGatherPress:mainfrom
mauteri merged 6 commits intoGatherPress:mainfrom
Conversation
PR Summary
|
mauteri
requested changes
Jun 4, 2024
| @@ -15,9 +15,12 @@ | |||
| <?php | |||
Contributor
There was a problem hiding this comment.
Let's rename the file site-check.php since this incorporates more than membership now.
Change the option gatherpress_suppress_membership_notification to gatherpress_suppress_site_notification. We can update this change in GatherPress Alpha.
mauteri
requested changes
Jun 4, 2024
| /* translators: %s: "enabling user registration here" (hyperlinked) */ | ||
| esc_html__( 'To ensure GatherPress functions optimally, we recommend enabling user registration. You can do so by %s', 'gatherpress' ), | ||
| esc_html__( 'To ensure GatherPress functions optimally, we recommend enabling user registration and setting your site\'s timezone. You can do so by %s and %s', 'gatherpress' ), | ||
| '<a href=' . esc_url( admin_url( 'options-general.php#users_can_register' ) ) . '>' |
Contributor
There was a problem hiding this comment.
^^ this will need to be fixed too.
mauteri
requested changes
Jun 4, 2024
| } else { | ||
| Utility::render_template( | ||
| sprintf( '%s/includes/templates/admin/setup/membership-check.php', GATHERPRESS_CORE_PATH ), | ||
| sprintf( '%s/includes/templates/admin/setup/site-check.php', GATHERPRESS_CORE_PATH ), |
Contributor
There was a problem hiding this comment.
Can you search/replace gatherpress_suppress_membership_notification and change to gatherpress_suppress_site_notification too? Thx!
mauteri
approved these changes
Jun 4, 2024
Contributor
mauteri
left a comment
There was a problem hiding this comment.
Looks good, thanks! I'll tag 0.29.0 and then push a change to GatherPress Alpha and then merge this.
mauteri
reviewed
Jun 4, 2024
| <?php | ||
| printf( | ||
| /* translators: 1: Enabling user registration 2: Setting time zone */ | ||
| esc_html__( 'To ensure GatherPress functions optimally, we recommend enabling user registration and setting your site\'s timezone. You can do so by %1$s and %2$s', 'gatherpress' ), |
Contributor
There was a problem hiding this comment.
Missed this, can you add a period at the end?
You can do so by %1$s and %2$s.
mauteri
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a second link to admin message for timezone
Taken to the setting for Timezone