Skip to content

Fix sonarcloud issues pointed out.#1250

Merged
mauteri merged 2 commits intodevelopfrom
version-0.33.0-beta.1
Dec 5, 2025
Merged

Fix sonarcloud issues pointed out.#1250
mauteri merged 2 commits intodevelopfrom
version-0.33.0-beta.1

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Dec 5, 2025

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Dec 5, 2025

PR Summary

  • Global Variable Removed
    The unnecessary global variable that existed in the rsvp_sorting_orderby function has been removed. This cleanup will make the function less complex and easier to understand.

  • Return Statement Simplified
    In the rsvp_sorting_orderby function, the statement used to indicate the calculation result that should be 'returned' or 'given back' has been simplified. This will make its use and intention clear to improve maintainability.

  • Commented-Out Code Removed
    The previously commented-out instructions in the venue_sorting_orderby function have been removed. These are codes that were not being used but were kept for possible future reference. Their removal will keep the code clean and focused, reducing any confusion arising from unused code.

  • Simplified Venue Sorting Clause
    The venue_sorting_orderby function is now directly giving back the sorting instruction related to venue names. This enhances readability by avoiding an indirect way of specifying this instruction. The code is now straightforward in sorting venues based on their names, thus improving comprehension.

@mauteri mauteri marked this pull request as ready for review December 5, 2025 22:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

Preview changes with Playground

You can preview the recent changes for PR#1250 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit 1808371 into develop Dec 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant