Skip to content

Fix JS formatting config to match WordPress standards.#1165

Closed
mauteri wants to merge 3 commits intodevelopfrom
fix-js-formating-config
Closed

Fix JS formatting config to match WordPress standards.#1165
mauteri wants to merge 3 commits intodevelopfrom
fix-js-formating-config

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Aug 11, 2025

Description of the Change

@carstingaxion @JordanPak @jmarx if any of you have JavaScript changes in your PR, please pull in changes from this branch and run npm run lint:js:fix before pulling in changes from develop branch to help avoid conflicts. I'm creating another PR to format all JavaScript to match WordPress standards, which is something I've been meaning to do for a while.

I'll update this PR when the changes are merged.

Once we're all good, we can close this.

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Aug 11, 2025

PR Summary

  • New Formatting and Internationalization Rules
    Introduced a new tool configuration that extends coding standards provided by WordPress. This includes new formatting rules and specifies permissible text domains for language translation purposes.

  • Removal of Old Configuration File
    The old tool configuration file has been deleted as we move towards the new format.

  • Updated Tool and Library Versions
    There are updates to several tools and libraries that our system uses:

    • The WordPress coding standard tool has been upgraded.
    • A new library for code formatting, Prettier, has been added.
    • Various other utilities and libraries have been updated to their latest versions.
  • Updated Package Dependencies
    The versions and integrity checks for several of our system's dependent packages have been updated to their latest releases. This is crucial for system stability and to benefit from the latest security patches and bug fixes.

@mauteri
Copy link
Copy Markdown
Contributor Author

mauteri commented Aug 11, 2025

PR for change to be merged into develop. #1166

"moment": "^2.30.1",
"moment-timezone": "^0.6.0",
"playwright": "^1.53.1",
"prettier": "^3.6.2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of this because it's a sub-dep and we're not directly invoking it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

@mauteri
Copy link
Copy Markdown
Contributor Author

mauteri commented Dec 7, 2025

This should no longer be needed. Closing...

@mauteri mauteri closed this Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants