Add a privacy policy content suggestion#1130
Conversation
PR Summary
|
| return; | ||
| } | ||
| $content = '<h2>' . __( 'Inform your visitors about GatherPress\' use of OpenStreetMap services.', 'gatherpress' ) . '</h2>' | ||
| . '<p><strong class="privacy-policy-tutorial">' . __( 'Suggested Text:', 'default' ) . '</strong> ' |
There was a problem hiding this comment.
No, it's intentional.
GatherPress does not need to stress the translation contributors with defaults that are translated a thousand times.
There was a problem hiding this comment.
Okay, I would omit it then and just have __( 'Suggested Text:' ) since default is the default and wp plugins guidelines is flagging it. Unless there's a reason not to do that.
There was a problem hiding this comment.
This is a little funny, because
I did exactly what you suggest in my commits here before (I guess) phpcs complained about the missing 'default' textdomain.
So I added it, expecting it to work now.
Ok, now what?
There was a problem hiding this comment.
Are you saying PHPCS complains if you leave it off and WP Plugin Guidelines complains if it's not "gatherpress"? Maybe don't include it and if PHPCS complains, add a PHPCS Ignore.
There was a problem hiding this comment.
@carstingaxion Try changing tested up to 6.8.1 to just 6.8. Seems that is what it is erroring on (which is new, as it's been that way for awhile).
There was a problem hiding this comment.
If that fixes it, we can put in a PR to change that and pull it into all PRs we're working on.
There was a problem hiding this comment.
All checks have passed
18 successful checks
That did it.
So next, I'm going top re-add the 'default' textdomain and remove the phpcs:ignore statement.
There was a problem hiding this comment.
So next, I'm going top re-add the 'default' textdomain and remove the phpcs:ignore statement.
Which worked out very well, with no errors.
Do you still need additional information on the Why & How of this idea @mauteri or are you able to merge it?
There was a problem hiding this comment.
@carstingaxion I'll get this on my list to do final review and merge if looks good. Thx!
Preview changes with PlaygroundYou can preview the recent changes for PR#1130 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
|
Hooray 🎉 and thanks for merging @mauteri ! |
Description of the Change
Closes #875
How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist: