Skip to content

Prep work for comment flow for open RSVP and small fixes#1103

Merged
mauteri merged 25 commits intodevelopfrom
GP-1090
May 24, 2025
Merged

Prep work for comment flow for open RSVP and small fixes#1103
mauteri merged 25 commits intodevelopfrom
GP-1090

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented May 6, 2025

Description of the Change

Mostly adjusts how RSVP comments are handled so they can be identified by email as well as user ID for new open RSVP flow that's to be developed.

New RSVP list table view.

Other small fixes and adjustments found with Event List styling and Block Guard were addressed.

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @mauteri

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented May 6, 2025

PR Summary

  • Improved Interaction with Comments:
    • The updates allow users to leave empty comments and to modify existing comment fields. Comments can now also be identified as 'gatherpress RSVPs', a specific comment category, and can be classified differently based on their RSVP status.
    • The system will now notify users if they are trying to send a duplicate RSVP.
  • Avatar Retrieval Revisions:
    • The system has been adjusted to get user avatars based on the author's email, adding in a fallback to utilize the user's identification when an email is not provided.
    • Privacy is respected by ensuring that if users post an anonymous RSVP, their email does not appear.
  • Improved Comment Data Processing:
    • Certain response mechanisms have been simplified in the system, through reducing unnecessary checks related to user info and status.
    • How the system generates the URLs for avatar photos now follows the updated email-centric method.
  • Streamlined Code Base:
    • Extraneous code elements have been removed, such as the needless import of the Event class, making the codebase more efficient and easier to manage.

@patriciabt
Copy link
Copy Markdown
Collaborator

Testing now, I love the RSVPs admin page.
Issue: I cannot re-approve someone I unapproved earlier
Feature request: a filter at the top, for event, date, topic, venue (like post filters for date and category)

@patriciabt
Copy link
Copy Markdown
Collaborator

Testing further, if I add again the user (here admin, it's in the playground :) ) it appears twice in the RSVP list, once pending, once approved

image

@github-actions
Copy link
Copy Markdown
Contributor

Preview changes with Playground

You can preview the recent changes for PR#1103 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri changed the title Started testing ideas of leveraging comment flow for RSVP with a comm… Prep work for comment flow for open RSVP and small fixes May 24, 2025
@mauteri mauteri marked this pull request as ready for review May 24, 2025 13:32
@mauteri mauteri merged commit f517836 into develop May 24, 2025
19 checks passed
@mauteri mauteri deleted the GP-1090 branch May 24, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants