Skip to content

Create artifacts directory in global-setup.js.#1097

Merged
mauteri merged 2 commits intodevelopfrom
e2e-playground-setup
May 5, 2025
Merged

Create artifacts directory in global-setup.js.#1097
mauteri merged 2 commits intodevelopfrom
e2e-playground-setup

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented May 5, 2025

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mauteri mauteri marked this pull request as ready for review May 5, 2025 02:33
@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented May 5, 2025

PR Summary

  • Removed 'fs' module import from 'gatherpress-admin.spec.js'
    This part of the code that was previously responsible for the file system operations has been removed from 'gatherpress-admin.spec.js'.

  • Eliminated 'artifacts' directory checking/creation from 'gatherpress-admin.spec.js'
    We also removed the part of the code that checks if the 'artifacts' directory exists, and if not, creates it within 'gatherpress-admin.spec.js'.

  • Added 'fs' module import in 'global-setup.js'
    We've incorporated the module for handling file system operations into 'global-setup.js' to centralize these operations.

  • Included 'artifacts' directory checking/creation in 'global-setup.js'
    Now, the 'global-setup.js' file will be responsible for checking the existence of the 'artifacts' directory, and creating it if needed. This makes the setup of necessary structures more consistent and centralized.

@mauteri mauteri merged commit 4c9b221 into develop May 5, 2025
6 checks passed
@mauteri mauteri deleted the e2e-playground-setup branch May 5, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant