Allow multiple venue blocks per event#1095
Merged
mauteri merged 8 commits intoGatherPress:developfrom May 5, 2025
Merged
Conversation
mauteri
requested changes
May 3, 2025
src/components/OpenStreetMap.js
Outdated
| } = props; | ||
|
|
||
| const [Leaflet, setLeaflet] = useState(null); | ||
| const mapId = `map-${instanceId || Math.random().toString(36).substr(2, 9)}`; |
Contributor
There was a problem hiding this comment.
Can use uuid here. Example: https://github.com/GatherPress/gatherpress/blob/develop/src/blocks/dropdown/edit.js#L85
Collaborator
Author
There was a problem hiding this comment.
@mauteri Done. And fixed a couple other things
mauteri
requested changes
May 4, 2025
src/components/OpenStreetMap.js
Outdated
| longitude, | ||
| } = props; | ||
| const [Leaflet, setLeaflet] = useState(null); | ||
| const mapId = `map-${`dropdown-${uuidv4()}`}`; |
Contributor
There was a problem hiding this comment.
Should be:
const mapId = `map-${uuidv4()}`;
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#1095 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: