Skip to content

Added a new check to determine if gatherpress has already been installed/activated#1094

Merged
mauteri merged 2 commits intodevelopfrom
GP-1071
May 8, 2025
Merged

Added a new check to determine if gatherpress has already been installed/activated#1094
mauteri merged 2 commits intodevelopfrom
GP-1071

Conversation

@stephenerdelyi
Copy link
Copy Markdown
Collaborator

@stephenerdelyi stephenerdelyi commented May 2, 2025

Description of the Change

#1071

Closes GP-1071

How to test the Change

Try to activate 2 different versions of GP at the same time and you will see an activation error message

Changelog Entry

Added - new check to search for other instances of GP installation

Credits

@stephenerdelyi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 2, 2025

Preview changes with Playground

You can preview the recent changes for PR#1094 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@stephenerdelyi stephenerdelyi requested a review from mauteri May 2, 2025 15:01
@mauteri
Copy link
Copy Markdown
Contributor

mauteri commented May 2, 2025

@stephenerdelyi let's just add that deactivate plugin to this like we chatted about. Thanks!

@stephenerdelyi
Copy link
Copy Markdown
Collaborator Author

@stephenerdelyi let's just add that deactivate plugin to this like we chatted about. Thanks!

As we discussed in slack, there's no way to identify which plugin to deactivate, just the first one loaded which can cause other concerns. We decided since this is so rare, the current implementation is fine.

@mauteri mauteri merged commit 1e767b9 into develop May 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants