Merged
Conversation
… type string is deprecated Also replaced strpos() with str_contains(). str_contains() was introduced in WP 5.9 as polyfill, min WP version is set to 6.7. Ref: GatherPress#1047
…f type string is deprecated Added a ! empty() check. This will catch more than just null, but any other empty result will end up in an empty array and thus in skipping the foreach, so bailing out early will be a bit cheaper and cleaner. Ref: GatherPress#1076
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#1077 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This fixes #1076 by adding a
! empty()check. And #1047 by checking if the given array has the key we want to check.Also replaced
strpos()withstr_contains()as it is available as polyfill since WordPress 5.xCloses #1076
Closes #1047
How to test the Change
Open a topic listing with WP_DEBUG active.
Changelog Entry
Credits
Props @apermo, @shawfactor
Checklist: