Skip to content

Started unit test for Modal.#1015

Merged
mauteri merged 3 commits intodevelopfrom
unit-tests
Feb 17, 2025
Merged

Started unit test for Modal.#1015
mauteri merged 3 commits intodevelopfrom
unit-tests

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Feb 17, 2025

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Feb 17, 2025

PR Summary

  • Removal of @group foobar annotation from Test_Modal_Manager class
    We have taken out a special label ('@group foobar') from the 'Test_Modal_Manager' class, which was no longer needed.
  • Introduction of a new file and class
    A new file named 'class-test-modal.php' has been added, which introduces a class called 'Test_Modal'.
  • Test of setup_hooks method
    The 'Test_Modal' class now includes a method for checking if the 'setup_hooks' function works as expected within the 'Modal' class. It achieves this by confirming the right filters are registered during setup.
  • Validation of hooks associated with Modal class
    To guarantee the 'Modal' class functions as expected, we've established a list of expected hooks in the 'test_setup_hooks' method. This will ensure all the connections in the 'Modal' class are valid and successfully registered.

@mauteri mauteri marked this pull request as ready for review February 17, 2025 23:53
@mauteri mauteri merged commit b71b61e into develop Feb 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant