Skip to content

Looooong timezone-array needed everywhere? #923

@carstingaxion

Description

@carstingaxion

Describe your question

Does GatherPress really need all possible timezones:

  • in the frontend markup?
  • in the backend markup?
  • on every page load?

https://github.com/carstingaxion/gatherpress/blob/02358ab60318a7464e31865ffea0f3bb8c961809/includes/core/classes/class-assets.php#L306

@swissspidy: Aside: just adding a script tag like this is usually not a good idea. You should at least use wp_print_inline_script_tag. Even better, attach it to a specific script with wp_add_inline_script.

@carstingaxion: I wanted to suggest the same, even that the relevant data - the timezones, in this case - are only used for the Event Date Block (#684)

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingquestionFurther information is requested

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions