Allow pwntools to load on Windows#1449
Merged
Merged
Conversation
Fixes loading of pwntools on Windows. `from pwn import *` works. It allows to use some operating system agnostic features of pwntools out of the box. This is inspired by Gallopsled#996. Some features fail or even crash (local processes, gdb, assemble/disassemble) and console colors are still not displayed correctly, but those can be addressed separately.
Arusekk
requested changes
Mar 16, 2020
Arusekk
left a comment
Member
There was a problem hiding this comment.
I didn't know it would be so easy to enable loading on windows. :D
The code of term module needs some attention lately, and possibly a rework using more curses, and less assumptions. When you fix the one drawback, I will happily merge your changes.
|
|
||
| def testpwnproc(cmd): | ||
| import fcntl | ||
| import termios |
Member
There was a problem hiding this comment.
This is good, will also possibly speed up the whole thing, since these imports are just for the tests.
Member
Author
|
I didn't know about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes loading of pwntools on Windows.
from pwn import *works. Most of the tweaks were required around thepwnlib.termmodule where most functionality got disabled due to modules only supporting linux.It allows to use some operating system agnostic features of pwntools out of the box.
This is inspired by #996.
Some features fail or even crash (local processes, gdb, assemble/disassemble) and console colors are still not displayed correctly, but those can be addressed separately.
I guess eventually tests could be run on AppVeyor or similar.