-
Notifications
You must be signed in to change notification settings - Fork 220
Closed
Description
Version: Gaffer 1.6.9.1
Description
I was looking at the Gaffer code for RenderMan to see if I could use the additional feature of PxrCamera and I stumbled upon this line:
gaffer/src/IECoreRenderMan/Camera.cpp
Line 132 in 5cbdc46
| if( boost::starts_with( name.c_str(), "ri:" ) ) |
Please be aware that I'm not familiar with c++ however this looks odd to me that we check if the name of the camera start with ri:, only to one line below use the parameterName variable instead.
gaffer/src/IECoreRenderMan/Camera.cpp
Lines 130 to 136 in 5cbdc46
| for( const auto &[parameterName, parameterValue] : camera->parameters() ) | |
| { | |
| if( boost::starts_with( name.c_str(), "ri:" ) ) | |
| { | |
| ParamListAlgo::convertParameter( RtUString( parameterName.c_str() + 3 ), parameterValue.get(), projectionParamList ); | |
| } | |
| } |
So my assumption is that it's a typo were parameterName was meant instead of name ?
Apologies if this is a not an actual issue and I have misunderstood the code.
Liam.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels