Skip to content

typo in IECoreRenderMan.Camera.cpp for arbitrary params #6775

@MrLixm

Description

@MrLixm

Version: Gaffer 1.6.9.1

Description

I was looking at the Gaffer code for RenderMan to see if I could use the additional feature of PxrCamera and I stumbled upon this line:

if( boost::starts_with( name.c_str(), "ri:" ) )

Please be aware that I'm not familiar with c++ however this looks odd to me that we check if the name of the camera start with ri:, only to one line below use the parameterName variable instead.

for( const auto &[parameterName, parameterValue] : camera->parameters() )
{
if( boost::starts_with( name.c_str(), "ri:" ) )
{
ParamListAlgo::convertParameter( RtUString( parameterName.c_str() + 3 ), parameterValue.get(), projectionParamList );
}
}

So my assumption is that it's a typo were parameterName was meant instead of name ?

Apologies if this is a not an actual issue and I have misunderstood the code.
Liam.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions