Skip to content

Better definition of async exceptions#53

Merged
Gabriella439 merged 1 commit intoGabriella439:masterfrom
snoyberg:master
May 7, 2018
Merged

Better definition of async exceptions#53
Gabriella439 merged 1 commit intoGabriella439:masterfrom
snoyberg:master

Conversation

@snoyberg
Copy link
Copy Markdown
Contributor

@snoyberg snoyberg commented May 7, 2018

syncIO previously relied upon the unexceptionalio package, which does
not use the standard definition from base of an asynchronous exception.
This brings errors in line with other libraries in the ecosystem for
recovering from all exceptions.

@snoyberg
Better definition of async exceptions
4eb9e84 
syncIO previously relied upon the unexceptionalio package, which does
not use the standard definition from base of an asynchronous exception.
This brings errors in line with other libraries in the ecosystem for
recovering from all exceptions.
@Gabriella439
Copy link
Copy Markdown
Owner

Gabriella439 commented May 7, 2018

I assume this is related to the discussion in singpolyma/unexceptionalio#9

I think this is a good change because it matches the stated contract of syncIO to ignore asynchronous exceptions. However, I'd like to preserve the old behavior under a function of a new name (i.e. unexceptionalIO or whatever), since I think it's useful to have a function which tries to squeeze as many exceptions out of IO as possible

@snoyberg
Copy link
Copy Markdown
Contributor Author

snoyberg commented May 7, 2018

The function you're describing would "squeeze" less exception types out of IO, not more. And any function that squeezes more types out of IO would allow recovering from an async exception, which would be broken behavior.

@Gabriella439
Copy link
Copy Markdown
Owner

Gabriella439 commented May 7, 2018

Oh, weird. For some reason I thought that Unexceptional.fromIO just did a catch all on SomeException. Never mind, then. This is fine as is

@Gabriella439 Gabriella439 merged commit 36ae3e4 into Gabriella439:master May 7, 2018
@Gabriella439
Copy link
Copy Markdown
Owner

Gabriella439 commented May 7, 2018

I'll wait three days before uploading to Hackage, just in case @singpolyma has any proposed changes

@snoyberg
Copy link
Copy Markdown
Contributor Author

snoyberg commented May 7, 2018

Awesome, thanks!

@Gabriella439
Copy link
Copy Markdown
Owner

Gabriella439 commented May 7, 2018

You're welcome!

@singpolyma
Copy link
Copy Markdown

singpolyma commented May 7, 2018

It's your package, of course. I'll just have to move the wrappers into my package or a new package for users who want what unexceptional offers.

@singpolyma singpolyma mentioned this pull request May 7, 2018
Closed
@bitemyapp bitemyapp mentioned this pull request May 8, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snoyberg @Gabriella439 @singpolyma