Implemented Cross-Origin-Resource-Policy response header#86
Conversation
|
Thank you for this. I'll take a look at it today. |
jamie-taylor-rjj
left a comment
There was a problem hiding this comment.
Fantastic work, thanks for this @miguelcrpinto. I've spotted a typo in one of the classes - likely a copy-paste error. Would you mind taking a look when you have the chance?
We also need a major version bump in order to release to NuGet, but I'm happy taking that as there are (currently) two places where the version number will need to change. I'll also need to add the new header to the changelog. Again, I'm happy to take that task, too.
| /// Requests from any Origin (both same-site and cross-site) can read the resource. | ||
| /// Browsers are using this policy when an CORP header is not specified. | ||
| /// </summary> | ||
| public const string CrossOriginValue = "same-origin"; |
There was a problem hiding this comment.
🔧 I believe there is a typo in this string value. It should be "cross-origin".
It's an easy typo to make, too. So no worries 👍
There was a problem hiding this comment.
It was indeed a copy-paste issue! Fixed!
|
@jamie-taylor-rjj I also bumped the version and updated the changelog accordingly. Can you please check if I changed everything needed? |
|
In case you were wondering, I was using this guide when choosing emoji for the PR comments. Looking at this new version of the PR now, live on Twitch. |
jamie-taylor-rjj
left a comment
There was a problem hiding this comment.
Fantastic work @miguelcrpinto. Thank you for your contribution.
|
closes #76 |
|
Thanks! I managed to still watch a few minutes of the review and merge on twitch! |
Implemented Cross-Origin-Resource-Policy response header according to the description on issue #76