Fix .NET SDK mismatches in actions#147
Merged
jamie-taylor-rjj merged 3 commits intomainfrom Dec 11, 2024
Merged
Conversation
Contributor
GaProgMan
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this PR
This project builds for both .NET 8 and .NET 9 (at the time of PR creation), however some GitHub actions where only making use of .NET 9. The SDKs should be backward compatible, but it has been seen (across multiple different actions) that this is not the case. An example is a recent (at the time of PR creation) run of the CodeQL analysis task which fails for the following error (which has been cleaned up for convenience):
The relevant lines of which are:
You must install or update .NET to run this application.(first line of above)error : The following frameworks were found: 9.0.0 at [/usr/share/dotnet/shared/Microsoft.AspNetCore.App](the final few lines, combined for convenience)The fix included in this PR is to explicitly install the relevant .NET SDKs (at the time of PR creation, both .NET 8 and 9) in each action where it is required.
Note
This might be a temporary problem (see: actions/runner-images#10973 (comment)), but it's also better to be explicit about the dependencies used. So these changes (assuming they work, and Github actions can only be tested ON GitHub) will likely stay in place, being updated when new SDKs are required or runtimes are supported by the project.
PR Checklist
Feel free to either check the following items (by place an
xinside of the square brackets) or by replacing the square brackets with a relevant emoji from the following list:Essential
These items are essential and must be completed for each commit. If they are not completed, the PR may not be accepted.
dotnet-formatcommand and fixed any .editorconfig issuesOptional
Any Other Information
This section is optional, but it might be useful to list any other information you think is relevant.