Conversation
|
we need the dep loader load up mods for curse launcher. Will this pr make it impossible ? |
the dep loader we use is directly inside NH core mod |
mitchej123
left a comment
There was a problem hiding this comment.
Is this safe removing things from the public API? Do other mods depend on those?
I think that's why we emptied them out instead of removing them..
it's not a public api, no one is supposed to call these methods directly, other mods should have a dependency file in their ressources and that's it What other mods did was copy paste this entire class in their mod as well, so emptying out this class won't cause issues in the other mods that copy pasted all the original code |
mitchej123
left a comment
There was a problem hiding this comment.
I suppose it's fine provided you've tested it in the full pack. Can always add it back if it's causing crashes or add some ASM...
|
yippeeee crash with mekanism |
|
@Alexdoru https://github.com/Thorfusion/Mekanism-Community-Edition/blob/1.7.10/src/main/java/mekanism/common/asm/LoadingHook.java#L12 Seems like at least the |
this mod is stupid and did not understand how to use codechicken's dependency loader |
looking at it this mod doesn't even have a dependency.info file so it's starting the dependency loader for nothing lol |
No description provided.