Skip to content

Incompatibility with old CodeChickenCore versions #23

@ThePixelbrain

Description

@ThePixelbrain

Affected versions: CodeChickenCore-1.3.0+
Log: https://pastebin.com/u9zd7FVC

Short description:
If the client is running the GTNH fork of CCC but the server is still running the old, upstream CCC, the clients gets kicked upon joining the server.
This scenario might happen when playing old 1.7.10 (FTB) modpacks where servers still run the original CCC.

Steps to reproduce:

  1. Download the latest GTNH CodeChickenCore and NEI.
  2. Start a server running the original CCC and NEI.
  3. Try to connect. You'll get kicked instantly and the above linked log is produced.

Suggested solution:
This issue is likely caused by commit d6e2b94, being part of GTNH-Museum/CodeChickenLib#12. The packet now sends an Integer instead of a Short for the itemID.
I'm uncertain what the ideal solution to this would be as I'm no expert in the modded MC ecosystem. Maybe it's possible to detect what version the remote side is running and decide whether to send an int or short. Maybe one could also check if NotEnoughIDs is present as it seems like this is patch was made for this mod specifically?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions