Bump dependencies#138
Conversation
|
I'd love to see this move forward; @fmckeogh could you fix these errors or would you be amenable to my opening another PR that passes CI? Thanks for starting this. |
|
@ahl Of course! Sorry I missed the errors, doing it now:) |
|
@ahl All except 1.37.0 passing due to updating |
|
I would suggest leaving indexmap at 1.6.2. I think the most useful of your changes are the ones you noted in this PR description: uuid, arrayvec, and (maybe) pretty_assertions |
|
@ahl Fixed, but unfortunately it looks like UUID 1.0.0 requires |
|
Hello! First thank you for your pull request, I have written the same. As |
|
@GREsau what do you think of bumping the minimum required rustc version from 1.37 to 1.46? |
|
I don't think I can merge this as-is even if I do increase MSRV and tests to 1.46+, as this change will break backward compatibility. Any users currently using the old versions of I've whipped up an alternative change in #142 which supports the newer crate versions in a backward-compatible manner, specifically by requiring the new feature flags I presume this would be sufficient for what you need? If so I'll finish and merge it |
|
Sounds good to me:) Closing in favour of #142 |
uuid0.8 -> 1.0arrayvec0.5 -> 0.7pretty_assertions0.6.1 -> 1.2.1serde_derive_internals0.25 -> 0.26Also the maintainers may wish to consider this post about specifying precise dependency versions https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277, if they agree I can quickly make those changes as part of this PR.