Skip to content

Bump dependencies#138

Closed
fmckeogh wants to merge 1 commit into
GREsau:masterfrom
fmckeogh:master
Closed

Bump dependencies#138
fmckeogh wants to merge 1 commit into
GREsau:masterfrom
fmckeogh:master

Conversation

@fmckeogh

Copy link
Copy Markdown
  • uuid 0.8 -> 1.0
  • arrayvec 0.5 -> 0.7
  • pretty_assertions 0.6.1 -> 1.2.1
  • serde_derive_internals 0.25 -> 0.26

Also the maintainers may wish to consider this post about specifying precise dependency versions https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277, if they agree I can quickly make those changes as part of this PR.

@ahl

ahl commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

I'd love to see this move forward; @fmckeogh could you fix these errors or would you be amenable to my opening another PR that passes CI? Thanks for starting this.

@fmckeogh

Copy link
Copy Markdown
Author

@ahl Of course! Sorry I missed the errors, doing it now:)

@fmckeogh

fmckeogh commented Apr 25, 2022

Copy link
Copy Markdown
Author

@ahl All except 1.37.0 passing due to updating indexmap. Should I revert this to 1.6.2 or update the pinned version being used in CI?

@ahl

ahl commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

I would suggest leaving indexmap at 1.6.2. I think the most useful of your changes are the ones you noted in this PR description: uuid, arrayvec, and (maybe) pretty_assertions

@fmckeogh

Copy link
Copy Markdown
Author

@ahl Fixed, but unfortunately it looks like UUID 1.0.0 requires rustc 1.46.0 or newer. What would you like to do?

@FlorentinDUBOIS

Copy link
Copy Markdown

Hello! First thank you for your pull request, I have written the same. As uuid need at least rust 1.46.0 and we are at rust 1.60.0, maybe it is time to move the msrv to at least the uuid one?

@ahl

ahl commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

@GREsau what do you think of bumping the minimum required rustc version from 1.37 to 1.46?

@GREsau

GREsau commented May 15, 2022

Copy link
Copy Markdown
Owner

I don't think I can merge this as-is even if I do increase MSRV and tests to 1.46+, as this change will break backward compatibility. Any users currently using the old versions of uuid/arrayvec with the corresponding features of schemars will be broken.

I've whipped up an alternative change in #142 which supports the newer crate versions in a backward-compatible manner, specifically by requiring the new feature flags uuid1/arrayvec07 to be enabled.

I presume this would be sufficient for what you need? If so I'll finish and merge it

@fmckeogh

Copy link
Copy Markdown
Author

Sounds good to me:) Closing in favour of #142

@fmckeogh fmckeogh closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants