Change likelihood defaults #1985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesnie
approved these changes
Sep 26, 2022
gpflow/config/__config__.py
Outdated
| * ``GPFLOW_FLOAT``: "float16", "float32", or "float64" | ||
| * ``GPFLOW_POSITIVE_BIJECTOR``: "exp" or "softplus" | ||
| * ``GPFLOW_POSITIVE_MINIMUM``: Any positive float number | ||
| * ``LIKELIHOODS_POSITIVE_MINIMUM``: Any positive float number |
Member
There was a problem hiding this comment.
We should probably prepend GPFLOW_ for consistency with the above...
Suggested change
| * ``LIKELIHOODS_POSITIVE_MINIMUM``: Any positive float number | |
| * ``GPFLOW_LIKELIHOODS_POSITIVE_MINIMUM``: Any positive float number |
11 tasks
11 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1985 +/- ##
===========================================
+ Coverage 98.06% 98.16% +0.09%
===========================================
Files 97 97
Lines 5437 5458 +21
===========================================
+ Hits 5332 5358 +26
+ Misses 105 100 -5
☔ View full report in Codecov by Sentry. |
Member
Author
|
With plural |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type: bugfix / enhancement
Summary
GPflow had a feature of setting the minimal positive value using
gpflow.config.set_default_positive_minimum. Recently, the default minimum boundary for positive values in scalar likelihoods has been changed to in module global variable with fixed value. That introduced a couple of issues:positive_minimumconfig value, as it was supposed to control all positive values in the GPflow package.configwas supposed to be a single controlling centre.This PR introduces
likelihoods_positive_minimumin config that controls positive values in scalar likelihoods.PR checklist
make format)make check-all)