Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Fix interpolation-related IR verification failures#1790

Merged
jayfoad merged 2 commits intoGPUOpen-Drivers:devfrom
jayfoad:interpolation-verification
May 13, 2022
Merged

Fix interpolation-related IR verification failures#1790
jayfoad merged 2 commits intoGPUOpen-Drivers:devfrom
jayfoad:interpolation-verification

Conversation

@jayfoad
Copy link
Copy Markdown
Member

@jayfoad jayfoad commented Apr 28, 2022

Previously the modified test would fail with:

immarg operand has non-immediate parameter
%66 = add i32 3, 0
%67 = call float @llvm.amdgcn.interp.p1(float %64, i32 immarg 0, i32 immarg %66, i32 %PrimMask) #3

@jayfoad jayfoad marked this pull request as ready for review April 28, 2022 15:06
@jayfoad jayfoad requested a review from a team as a code owner April 28, 2022 15:06
jayfoad
jayfoad commented Apr 28, 2022
View reviewed changes
@jayfoad jayfoad mentioned this pull request Apr 28, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 28, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_2240159732/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 28, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_2240159732/index.html.
Configuration: release_clang_coverage.

amdrexu
amdrexu previously approved these changes Apr 29, 2022
View reviewed changes
amdrexu
amdrexu previously approved these changes Apr 29, 2022
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 29, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_2244275182/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 29, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_2244275182/index.html.
Configuration: release_clang_coverage.

@amdvlk-admin
Copy link
Copy Markdown

amdvlk-admin commented Apr 29, 2022

Test summary for commit 585ebb2

CTS tests (Failed: 1/187694)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 36645/65183 (56.2%)
    • Failed: 0/65183 (0.0%)
    • Not Supported: 28538/65183 (43.8%)
    • Warnings: 0/65183 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 31111/57328 (54.3%)
    • Failed: 0/57328 (0.0%)
    • Not Supported: 26217/57328 (45.7%)
    • Warnings: 0/57328 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 37802/65183 (58.0%)
    • Failed: 1/65183 (0.0%)

      Failures:

      FAILURE: dEQP-VK.synchronization.basic.event.multi_secondary_command_buffer
Stack trace: Script:
synchronizationWrapper->queueSubmit(queue, *fence): VK_TIMEOUT at vktSynchronizationBasicEventTests.cpp:337

    • Not Supported: 27380/65183 (42.0%)
    • Warnings: 0/65183 (0.0%)

jayfoad added 2 commits May 11, 2022 14:36
@jayfoad
Fix interpolation-related IR verification failures
8bc7f39 
Previously the modified test would fail with:

immarg operand has non-immediate parameter
  %66 = add i32 3, 0
  %67 = call float @llvm.amdgcn.interp.p1(float %64, i32 immarg 0, i32 immarg %66, i32 %PrimMask) GPUOpen-Drivers#3
@jayfoad
Fix review comments
9ac43b3
@jayfoad jayfoad force-pushed the interpolation-verification branch from 585ebb2 to 9ac43b3 Compare May 11, 2022 13:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 11, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_shadercache_coverage_assertions_2307393666/index.html.
Configuration: release_clang_shadercache_coverage_assertions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 11, 2022

The LLPC code coverage report is available at https://storage.googleapis.com/amdvlk-llpc-github-ci-artifacts-public/coverage_release_clang_coverage_2307393666/index.html.
Configuration: release_clang_coverage.

@amdvlk-admin
Copy link
Copy Markdown

amdvlk-admin commented May 11, 2022

Test summary for commit 9ac43b3

CTS tests (Failed: 0/187823)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 36645/65226 (56.2%)
    • Failed: 0/65226 (0.0%)
    • Not Supported: 28581/65226 (43.8%)
    • Warnings: 0/65226 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 31111/57371 (54.2%)
    • Failed: 0/57371 (0.0%)
    • Not Supported: 26260/57371 (45.8%)
    • Warnings: 0/57371 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 37804/65226 (58.0%)
    • Failed: 0/65226 (0.0%)
    • Not Supported: 27422/65226 (42.0%)
    • Warnings: 0/65226 (0.0%)

1 similar comment
@amdvlk-admin
Copy link
Copy Markdown

amdvlk-admin commented May 12, 2022

Test summary for commit 9ac43b3

CTS tests (Failed: 0/187823)
  • Built with version 1.3.0.0
    • Rhel 8.2, Gfx10
    • Passed: 36645/65226 (56.2%)
    • Failed: 0/65226 (0.0%)
    • Not Supported: 28581/65226 (43.8%)
    • Warnings: 0/65226 (0.0%)
    Ubuntu 18.04, Gfx9
    • Passed: 31111/57371 (54.2%)
    • Failed: 0/57371 (0.0%)
    • Not Supported: 26260/57371 (45.8%)
    • Warnings: 0/57371 (0.0%)
    Ubuntu 20.04, Gfx8
    • Passed: 37804/65226 (58.0%)
    • Failed: 0/65226 (0.0%)
    • Not Supported: 27422/65226 (42.0%)
    • Warnings: 0/65226 (0.0%)

@jayfoad jayfoad merged commit dfe6a18 into GPUOpen-Drivers:dev May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amdrexu amdrexu amdrexu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jayfoad @amdvlk-admin @amdrexu