This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Revert "Do not generate dummy exports for PS on GFX10"#1354
Merged
JaxLinAMD merged 1 commit intoGPUOpen-Drivers:devfrom Aug 11, 2021
Merged
Revert "Do not generate dummy exports for PS on GFX10"#1354JaxLinAMD merged 1 commit intoGPUOpen-Drivers:devfrom
JaxLinAMD merged 1 commit intoGPUOpen-Drivers:devfrom
Conversation
There is a subtle interaction with fragment shaders which write to color buffers with no attachment. LLPC removes these outputs, but it appears some shaders are expecting an output to happen and relying on the results of a discard through this. This was not picked up by Vulkan CTS testing, persumably as the pipelines it uses are well-defined, but this behaviour does occur in game titles. The old dummy export behaviour was masking this problem by always exporting when discards occur. Revert to this behaviour while we investigate further. This reverts commit 533147b.
amdrexu
approved these changes
Aug 10, 2021
Test summary for commit 72cce05Driver commits used in build
CTS tests (Failed: 0/228724)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a subtle interaction with fragment shaders which write to
color buffers with no attachment. LLPC removes these outputs,
but it appears some shaders are expecting an output to happen
and relying on the results of a discard through this.
This was not picked up by Vulkan CTS testing, persumably as the
pipelines it uses are well-defined, but this behaviour does
occur in game titles.
The old dummy export behaviour was masking this problem by always
exporting when discards occur. Revert to this behaviour while
we investigate further.
This reverts commit 533147b.