Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Start porting the lowering passes to the new pass manager#1304

Merged
JaxLinAMD merged 1 commit intoGPUOpen-Drivers:devfrom
bsaleil:npm
Jul 8, 2021
Merged

Start porting the lowering passes to the new pass manager#1304
JaxLinAMD merged 1 commit intoGPUOpen-Drivers:devfrom
bsaleil:npm

Conversation

@bsaleil
Copy link
Copy Markdown
Contributor

@bsaleil bsaleil commented Jun 29, 2021

This patch starts porting the lowering passes added in SpirvLower::addPasses to the
new pass manager. It also makes some changes to the infrastructure for the new
pass manager to allow adding function analyses.

@bsaleil bsaleil requested review from amdrexu and trenouf as code owners June 29, 2021 18:34
@amdvlk-admin
Copy link
Copy Markdown

amdvlk-admin commented Jun 29, 2021

Test summary for commit a7b8f14

Driver commits used in build
  • CWPACK: amd-master 7387247eb9889ddcabbc1053b9c2052e253b088e
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev 93d6aba82af14ae57ae6d84a4cf0cca3d9aa8c6b
  • SPVGEN: dev 79f8e32dd7242d7d34fa0074f761c9d794f11811
  • XGL: dev 5c3c2dd430222cdf1b46c9d385e9c6c5e89604e1
  • LLVM-PROJECT: amd-gfx-gpuopen-dev 0cb96bc82ca13e0fef3684a4ac8f6eff50bce257
CTS tests (Failed: 0/228128)
  • Built with version 1.2.5.2
    • Rhel 8.2, Gfx10
    • Passed: 31146/57032 (54.6%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 25886/57032 (45.4%)
    Ubuntu 18.04, Gfx9
    • Passed: 31145/57032 (54.6%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 25887/57032 (45.4%)
    Ubuntu 20.04, Gfx8
    • Passed: 31459/57032 (55.2%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 25573/57032 (44.8%)
    Ubuntu 20.04, Gfx103
    • Passed: 34853/57032 (61.1%)
    • Failed: 0/57032 (0.0%)
    • Not Supported: 22179/57032 (38.9%)

@amdrexu amdrexu requested a review from piotrAMD June 30, 2021 02:33
@JaxLinAMD
Copy link
Copy Markdown
Contributor

JaxLinAMD commented Jun 30, 2021

@piotrAMD PING please help review this PR.

kuhar
kuhar reviewed Jun 30, 2021
View reviewed changes
@amdvlk-admin
Copy link
Copy Markdown

amdvlk-admin commented Jun 30, 2021

Test summary for commit 89177fc

Driver commits used in build
  • CWPACK: amd-master 7387247eb9889ddcabbc1053b9c2052e253b088e
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev 93d6aba82af14ae57ae6d84a4cf0cca3d9aa8c6b
  • SPVGEN: dev 79f8e32dd7242d7d34fa0074f761c9d794f11811
  • XGL: dev 0df9173340136b73ff2aa49647d18b8acd43ca5f
  • LLVM-PROJECT: amd-gfx-gpuopen-dev 0cb96bc82ca13e0fef3684a4ac8f6eff50bce257
CTS tests (Failed: 1/188379)
  • Built with version 1.2.5.2
    • Rhel 8.2, Gfx10
    • Passed: 31242/57279 (54.5%)
    • Failed: 0/57279 (0.0%)
    • Not Supported: 26037/57279 (45.5%)
    Ubuntu 18.04, Gfx9
    • Passed: 10184/16542 (61.6%)
    • Failed: 1/16542 (0.0%)

      Failures:

      FAILURE: dEQP-VK.binding_model.buffer_device_address.set3.depth3.basessbo.convertchecku64.store.replay.std140.frag
Stack trace: Script:
Crash

    • Not Supported: 6357/16542 (38.4%)
    Ubuntu 20.04, Gfx8
    • Passed: 31555/57279 (55.1%)
    • Failed: 0/57279 (0.0%)
    • Not Supported: 25724/57279 (44.9%)
    Ubuntu 20.04, Gfx103
    • Passed: 34949/57279 (61.0%)
    • Failed: 0/57279 (0.0%)
    • Not Supported: 22330/57279 (39.0%)

piotrAMD
piotrAMD reviewed Jul 2, 2021
View reviewed changes
@bsaleil
Copy link
Copy Markdown
Contributor Author

bsaleil commented Jul 7, 2021

/rebase

@kuhar
Copy link
Copy Markdown
Contributor

kuhar commented Jul 7, 2021

@bsaleil are you added as a collaborator to this repo?

/rebase

@bsaleil @kuhar
Start porting the lowering passes to the new pass manager
8b831a7 
This PR starts porting the lowering passes added in SpirvLower::addPasses to the
new pass manager. It also makes some changes to the infrastructure for the new
pass manager to allow adding function analyses.
@amdvlk-admin
Copy link
Copy Markdown

amdvlk-admin commented Jul 7, 2021

Test summary for commit 22f2a94

Driver commits used in build
  • CWPACK: amd-master 7387247eb9889ddcabbc1053b9c2052e253b088e
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev 652389aacbec397eeac3635ecbf6dc538251780c
  • SPVGEN: dev 79f8e32dd7242d7d34fa0074f761c9d794f11811
  • XGL: dev 0df9173340136b73ff2aa49647d18b8acd43ca5f
  • LLVM-PROJECT: amd-gfx-gpuopen-dev 0a3fa7fcc965c8e6d37ad16469bbf4ea8caf90ee
CTS tests (Failed: 0/229120)
  • Built with version 1.2.5.2
    • Rhel 8.2, Gfx10
    • Passed: 31242/57280 (54.5%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 26038/57280 (45.5%)
    Ubuntu 18.04, Gfx9
    • Passed: 31241/57280 (54.5%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 26039/57280 (45.5%)
    Ubuntu 20.04, Gfx8
    • Passed: 31555/57280 (55.1%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 25725/57280 (44.9%)
    Ubuntu 20.04, Gfx103
    • Passed: 34949/57280 (61.0%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 22331/57280 (39.0%)

@bsaleil
Copy link
Copy Markdown
Contributor Author

bsaleil commented Jul 7, 2021

@bsaleil are you added as a collaborator to this repo?

/rebase

I'm actually not sure but I think so.

@kuhar
Copy link
Copy Markdown
Contributor

kuhar commented Jul 7, 2021

I'm actually not sure but I think so.

Ah, you are a 'member' instead of 'collaborator', but I think this is not handled by the rebase action. I'll try to get this fixed.

@amdvlk-admin
Copy link
Copy Markdown

amdvlk-admin commented Jul 7, 2021

Test summary for commit 8b831a7

Driver commits used in build
  • CWPACK: amd-master 7387247eb9889ddcabbc1053b9c2052e253b088e
  • METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
  • PAL: dev 652389aacbec397eeac3635ecbf6dc538251780c
  • SPVGEN: dev 79f8e32dd7242d7d34fa0074f761c9d794f11811
  • XGL: dev 0df9173340136b73ff2aa49647d18b8acd43ca5f
  • LLVM-PROJECT: amd-gfx-gpuopen-dev 0a3fa7fcc965c8e6d37ad16469bbf4ea8caf90ee
CTS tests (Failed: 0/229120)
  • Built with version 1.2.5.2
    • Rhel 8.2, Gfx10
    • Passed: 31242/57280 (54.5%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 26038/57280 (45.5%)
    Ubuntu 18.04, Gfx9
    • Passed: 31241/57280 (54.5%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 26039/57280 (45.5%)
    Ubuntu 20.04, Gfx8
    • Passed: 31555/57280 (55.1%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 25725/57280 (44.9%)
    Ubuntu 20.04, Gfx103
    • Passed: 34949/57280 (61.0%)
    • Failed: 0/57280 (0.0%)
    • Not Supported: 22331/57280 (39.0%)

@JaxLinAMD JaxLinAMD merged commit 20f9d99 into GPUOpen-Drivers:dev Jul 8, 2021
@bsaleil bsaleil mentioned this pull request Aug 24, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amdrexu amdrexu Awaiting requested review from amdrexu

@trenouf trenouf Awaiting requested review from trenouf

2 more reviewers

@kuhar kuhar kuhar left review comments

@piotrAMD piotrAMD piotrAMD approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bsaleil @amdvlk-admin @JaxLinAMD @kuhar @piotrAMD