This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Fix latent translation issues of GLSL built-in pack functions#1300
Merged
amdrexu merged 1 commit intoGPUOpen-Drivers:devfrom Jun 29, 2021
Merged
Fix latent translation issues of GLSL built-in pack functions#1300amdrexu merged 1 commit intoGPUOpen-Drivers:devfrom
amdrexu merged 1 commit intoGPUOpen-Drivers:devfrom
Conversation
Test summary for commit d4e8dd9Driver commits used in build
CTS tests (Failed: 0/228128)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
linqun
previously approved these changes
Jun 28, 2021
Test summary for commit b9ea7d3Driver commits used in build
CTS tests (Failed: 0/228128)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
The pack functions packUnorm4x8/packSnorm4x8/packUnorm2x16/packSnorm2x16 always need a rounding calculation. This is missing in the translation. Change-Id: Ib8e53debf56b94fde54225592bf85db498cc3391
Test summary for commit 8ce121aDriver commits used in build
CTS tests (Failed: 0/228128)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
kuhar
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pack functions packUnorm4x8/packSnorm4x8/packUnorm2x16/packSnorm2x16
always need a rounding calculation. This is missing in the translation.
Change-Id: Ib8e53debf56b94fde54225592bf85db498cc3391