This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Improve codegen for conditional relocs#1228
Merged
JaxLinAMD merged 1 commit intoGPUOpen-Drivers:devfrom May 7, 2021
Merged
Conversation
Truncating the reloc value to i1 forces the backend to generate code that ignores the high bits of the reloc value. Using a compare with zero instead lets the backend generate slightly simpler code by folding the reloc into a compare instruction.
Test summary for commit 13044e1Driver commits used in build
CTS tests (Failed: 1/224667)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
s-perron
approved these changes
Apr 28, 2021
amdrexu
approved these changes
Apr 29, 2021
Test summary for commit 13044e1Driver commits used in build
CTS tests (Failed: 1/194551)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
Test summary for commit 13044e1Driver commits used in build
CTS tests (Failed: 0/224667)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncating the reloc value to i1 forces the backend to generate code
that ignores the high bits of the reloc value. Using a compare with
zero instead lets the backend generate slightly simpler code by folding
the reloc into a compare instruction.