modify igc writer for consistent rounding.#146
Merged
tsteven4 merged 3 commits intoGPSBabel:masterfrom Dec 9, 2017
Merged
Conversation
GPSBabelDeveloper
approved these changes
Dec 9, 2017
Collaborator
GPSBabelDeveloper
left a comment
There was a problem hiding this comment.
I have a feeling we have a lot of these in our future. It's something we need to look for in new formats and incoming patches, too.
Thanx.
Collaborator
Author
|
This original commit in this PR was problematic. It could end up with n degrees and 60000 milliminutes. The original test data that failed before the PR is 48.2709750, or 2,896,258.5 milliminutes. In this case any accumulated fp math errors can cause it to go either way. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uggh. writing code to use round(), which has defined behavior for halfway cases, unlike *printf. But it gets our CI passing again.