fix(posv): fix missing n_time in posv transactions#1925
Merged
shamardy merged 1 commit intoGLEECBTC:devfrom Aug 2, 2023
Merged
fix(posv): fix missing n_time in posv transactions#1925shamardy merged 1 commit intoGLEECBTC:devfrom
shamardy merged 1 commit intoGLEECBTC:devfrom
Conversation
Merged
smk762
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Tested locally and working to create successful withdrawals
smk762@pig:~/mm2_777$ ./connect_RDD.sh
{"result":"success","address":"RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg","balance":"51.76764736","unspendable_balance":"0","coin":"RDD","required_confirmations":5,"requires_notarization":false,"mature_confirmations":30}
smk762@pig:~/mm2_777$ ./withdraw2.sh RDD RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg 1
{"mmrpc":"2.0","result":{"tx_hex":"0200000001532551126b30dda21ad826c440413e1db8036c3bd87bf80aa1fce91b51457de5000000006a47304402207161eee616d2a9ab57a96dc3ad3168d80631e125ca776d7b91d51a9be9852b8d02205337e63bd849e70b20e462f9e4f66ea170dc091273539b1ac95d030027952603012103d8064eece4fa5c0f8dc0267f68cee9bdd527f9e88f3594a323428718c391ecc2ffffffff0200e1f505000000001976a914d346067e3c3c3964c395fee208594790e29ede5d88aca0c1972e010000001976a914d346067e3c3c3964c395fee208594790e29ede5d88acb84dc764b84dc764","tx_hash":"869f4770950becaaa00c92c8f0cfe2a98b2ffca166fb15eafb789a3399c8aef6","from":["RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg"],"to":["RssuXYmBuWE2WF3c1phKpr84sjoQQyZtgg"],"total_amount":"51.76764736","spent_by_me":"51.76764736","received_by_me":"51.76664736","my_balance_change":"-0.001","block_height":0,"timestamp":1690783160,"fee_details":{"type":"Utxo","coin":"RDD","amount":"0.001"},"coin":"RDD","internal_id":"","transaction_type":"StandardTransfer","memo":null},"id":0}smk762@pig:~/mm2_777$
smk762@pig:~/mm2_777$ ./sendrawtransaction.sh RDD 0200000001532551126b30dda21ad826c440413e1db8036c3bd87bf80aa1fce91b51457de5000000006a47304402207161eee616d2a9ab57a96dc3ad3168d80631e125ca776d7b91d51a9be9852b8d02205337e63bd849e70b20e462f9e4f66ea170dc091273539b1ac95d030027952603012103d8064eece4fa5c0f8dc0267f68cee9bdd527f9e88f3594a323428718c391ecc2ffffffff0200e1f505000000001976a914d346067e3c3c3964c395fee208594790e29ede5d88aca0c1972e010000001976a914d346067e3c3c3964c395fee208594790e29ede5d88acb84dc764b84dc764
{"tx_hash":"869f4770950becaaa00c92c8f0cfe2a98b2ffca166fb15eafb789a3399c8aef6"}
https://live.reddcoin.com/tx/869f4770950becaaa00c92c8f0cfe2a98b2ffca166fb15eafb789a3399c8aef6
Collaborator
shamardy
approved these changes
Aug 1, 2023
Collaborator
|
@reddink can you please rebase your branch to dev since it was based on main? |
Author
|
@shamardy |
caglaryucekaya
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a fix for the Reddcoin withdrawal issue.
electrum was reporting that it could not parse transaction
On investigating, the issue was a missing n_time field in the generated transaction
The fix now correctly considers when n_time is required, and the rawtransaction can be broadcast