Skip to content

add CI flows for adex-cli#1818

Merged
shamardy merged 4 commits intodevfrom
adex-cli-ci-flows
May 12, 2023
Merged

add CI flows for adex-cli#1818
shamardy merged 4 commits intodevfrom
adex-cli-ci-flows

Conversation

@onur-ozkan
Copy link
Copy Markdown

@onur-ozkan onur-ozkan commented May 11, 2023

blocker for #1768

Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the adex-cli-ci-flows branch from 2ecf523 to c18430a Compare May 11, 2023 08:30
Signed-off-by: ozkanonur <work@onurozkan.dev>
shamardy
shamardy previously approved these changes May 12, 2023
Copy link
Copy Markdown
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these important checks!

#1768 added some unit tests for CLI so we will need to add adex-cli unit tests CI checks too after the PR is merged.

Please also fix the merge conflicts related to the changelog file :)

…ex-cli-ci-flows

Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan
Copy link
Copy Markdown
Author

Added new pipeline for cargo test

Copy link
Copy Markdown
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

@shamardy shamardy merged commit f8ada95 into dev May 12, 2023
@shamardy shamardy deleted the adex-cli-ci-flows branch May 12, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants