Skip to content

Fix nft request for wasm target#1817

Merged
shamardy merged 6 commits intodevfrom
fix-wasm-nft
May 11, 2023
Merged

Fix nft request for wasm target#1817
shamardy merged 6 commits intodevfrom
fix-wasm-nft

Conversation

@laruh
Copy link
Copy Markdown

@laruh laruh commented May 10, 2023

This pr fixes error sending request in wasm

{"mmrpc":"2.0","error":"Transport: nft:252] wasm_http:160] Internal(\"JsValue(TypeError: Failed to construct 'Request': Request with GET/HEAD method cannot have body.\")","error_path":"nft","error_trace":"nft:252]","error_type":"Transport","error_data":"nft:252] wasm_http:160] Internal(\"JsValue(TypeError: Failed to construct 'Request': Request with GET/HEAD method cannot have body.\")","id":null}

@laruh laruh requested a review from onur-ozkan May 10, 2023 14:43
@onur-ozkan
Copy link
Copy Markdown

onur-ozkan commented May 10, 2023

It's sad we didn't catch this in tests. Can you write some integration tests for moralis?

onur-ozkan
onur-ozkan previously approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two non-blocker comments

@shamardy
Copy link
Copy Markdown
Collaborator

shamardy commented May 11, 2023

@laruh can you please resolve the merge conflict related to the changelog?

@laruh
Copy link
Copy Markdown
Author

laruh commented May 11, 2023

@laruh can you please resolve the merge conflict related to the changelog?

@shamardy Thanks, done

@shamardy shamardy merged commit fbe9f16 into dev May 11, 2023
@shamardy shamardy deleted the fix-wasm-nft branch May 11, 2023 16:02
@shamardy shamardy mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shamardy shamardy shamardy approved these changes

+1 more reviewer

@onur-ozkan onur-ozkan onur-ozkan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laruh @onur-ozkan @shamardy