Conversation
Path changed for 1.0.18 Co-authored-by: ca333 <ca333@users.noreply.github.com>
Introduces a new Python script that verifies the accessibility of files via URLs specified in .mk files from the depends/packages directory. The script parses the .mk files, resolves variables, builds URLs, and checks their availability, providing detailed output on the status of each dependency.
smk762
approved these changes
Jan 18, 2026
smk762
left a comment
There was a problem hiding this comment.
Confirmed all green ticks when run at f740eb7
[51/51] Checking zeromq... ✓ Ok
======================================================================
Summary: Ok: 51, Errors: 0, Skipped: 0
Confirmed bad url detected and error returned
[49/51] Checking rust... ✓ Ok
[50/51] Checking utfcpp... ✗ Connection Error (HTTP 0)
[51/51] Checking zeromq... ✓ Ok
======================================================================
Summary: Ok: 50, Errors: 1, Skipped: 0
Detailed error information:
✗ utfcpp - Connection Error (HTTP 0)
URL: https://invalid.example.com/nemtrif/utfcpp/archive/v3.1.tar.gz
Confirmed successful daemon build and launch.
Confirmed dameon cli responsive.
Collaborator
|
Should this check_dependency_urls.py script be executed from CI builds? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
This PR updates the
libsodiumdependency path to reflect its new download location and adds a new script to help validate dependency URLs used in the build system. The updated path ensures the correct version (e.g., 1.0.18) is fetched during builds, preventing build failures due to the moved or removed upstream location. Additionally, a Python script has been introduced that parses.mkfiles in the depends/packages directory, resolves variables, and checks that each dependency URL is reachable.Why:
A recent change in libsodium release distribution caused the previously used download path to become invalid, breaking the build process.
Manual verification of many dependency URLs is error-prone and slow, so the new script automates this check and can help catch broken URLs early in development and CI.