Merged
Conversation
gcharang
approved these changes
Jul 29, 2025
DeckerSU
reviewed
Jul 29, 2025
DeckerSU
left a comment
There was a problem hiding this comment.
Those same changes are needed in the Dockerfile as well. You applied them only in Dockerfile.release, but the main Dockerfile is also based on ubuntu:20.04. To avoid potential issues, you need to update both files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current output sent to dockerhub is faulty, as the GHA build environment
runs-on: ubuntu-22.04, but the docker base image was set to runFROM ubuntu:20.04.The result was the following errors on launching the images uploaded to dockerhub
By aligning the GHA build env and dockerfile base image, these errors will be avoided.