Skip to content

S8 preps#622

Merged
ca333 merged 21 commits intodevfrom
patch-s8-prepare
Aug 19, 2024
Merged

S8 preps#622
ca333 merged 21 commits intodevfrom
patch-s8-prepare

Conversation

@ca333
Copy link
Copy Markdown

@ca333 ca333 commented Aug 19, 2024

No description provided.

DeckerSU and others added 21 commits May 23, 2024 19:07
Pre-check the public keys array, season heights, and timestamps
before launching the daemon. This check prevents the daemon from
launching if some information in the important arrays is incorrectly
filled.
In the real KMD chain (not in the first blocks),
block.nBits will always be greater than KOMODO_MINDIFF_NBITS.
Therefore, the control will never enter this conditional statement.

Also "fee stealing" is impossible, since we have notary
proof tx (last tx in notary mined block).
For some reason, we were not allowed to have additional
vouts in the coinbase transaction if their total was
greater than 0.1 KMD. Therefore, a coinbase transaction
with 2.8 KMD in vout[0] and 0.2 KMD in vout[1] was forbidden.

Since this release, we are allowing such transactions.
We are not using height activation here to keep the code simple;
instead, we have just removed the restriction itself.
error: integer value -1 is outside the valid range of values [0, 3] for this enumeration type

- https://trac.macports.org/ticket/69103
- boostorg/numeric_conversion@50a1eae
Add Season 8 pubkeys and update hardfork constants
@ca333 ca333 requested review from DeckerSU, gcharang and smk762 August 19, 2024 08:20
@ca333 ca333 merged commit 18596cc into dev Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants