Conversation
|
Tested with increasing sizes of
Error occurs where expected, but is not very descriptive. |
src/script/standard.h
Outdated
| @@ -41,6 +43,11 @@ class CScriptID : public uint160 | |||
| }; | |||
|
|
|||
| static const unsigned int MAX_OP_RETURN_RELAY = 8192; //! bytes | |||
There was a problem hiding this comment.
Why do we still need MAX_OP_RETURN_RELAY (although you have introduced two different consts for kmd and AC)?
There was a problem hiding this comment.
Actually, it was just a default value, like static initialization. But you are right – since we don't use it anywhere, we can remove it. Done in a97380f .
| static const unsigned int MAX_OP_RETURN_RELAY = 8192; //! bytes | ||
|
|
||
| static const unsigned int MAX_OP_RETURN_RELAY_KMD = 140; /* 76 bytes of nota size + 64 bytes chain name */ | ||
| static const unsigned int MAX_OP_RETURN_RELAY_AC = 208; /* 144 bytes of nota size + 64 bytes chain name */ |
There was a problem hiding this comment.
I think 208 bytes is too low for marmara (although they currently do not sync to komodo)
There was a problem hiding this comment.
MCL is a different codebase. The values of MAX_OP_RETURN_RELAY_KMD and MAX_OP_RETURN_RELAY_AC were derived from the maximum possible sizes of notarization OP_RETURN in KMD itself and assetchains. Additionally, before setting these values, all existing chains were scanned to determine the maximum size of useful OP_RETURN, ensuring that everything needed would fit within the new restrictions.
No description provided.