Merged
Conversation
|
For making code better readable, i would recommend to do the same changes as following: But variant in PR is also looks good. |
|
Also this #378 (comment) is good point. |
Alrighttt
reviewed
Jul 27, 2020
Alrighttt
left a comment
There was a problem hiding this comment.
Will approve review after #378 (comment) is implemented.
Alrighttt
approved these changes
Jul 31, 2020
Alrighttt
left a comment
There was a problem hiding this comment.
This creates problems with the nspv clients trying to connect to these nodes. It does seem to be a nspv client issue(not returning ping p2p messages). The issue is not directly related to these changes, but something to keep in mind for the future as we begin to use nspv clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.