Skip to content

feat: Add prioritized coins display for unauthenticated users#3351

Merged
smk762 merged 4 commits intodevfrom
patch-assets-main-list
Nov 23, 2025
Merged

feat: Add prioritized coins display for unauthenticated users#3351
smk762 merged 4 commits intodevfrom
patch-assets-main-list

Conversation

@DeckerSU
Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU commented Nov 3, 2025

This PR adds priority-based sorting for the asset list displayed to unauthenticated users on the wallet page. Priority coins (BTC, KMD, ETH, BNB, LTC, DASH, ZEC, DOGE) are now displayed first in a specified order, followed by all other coins sorted alphabetically.

This change improves user experience by ensuring that when users first launch the wallet, they immediately see familiar and popular cryptocurrencies (such as Bitcoin, Ethereum, Komodo) instead of less-known assets that might appear first in alphabetical order (e.g., "1inch", "Aave", etc.). This makes the onboarding experience more intuitive and helps users quickly identify well-known assets.

Changes

1. Priority Tickers Configuration

  • Added unauthenticatedUserPriorityTickers constant in lib/app_config/app_config.dart
  • Defined as a List<String> to preserve order (BTC, KMD, ETH, BNB, LTC, DASH, ZEC, DOGE)
  • Order of coins in this list determines their display order

2. Asset List Sorting Logic

  • Modified AssetsList._groupAssetsByTicker() in lib/views/wallet/wallet_page/common/assets_list.dart
  • Implemented priority-based sorting for grouped asset view:
    • Priority tickers appear first, maintaining the order from unauthenticatedUserPriorityTickers
    • Non-priority tickers follow, sorted alphabetically

Behavior

For unauthenticated users (AuthorizeMode.noLogin and AuthorizeMode.hiddenLogin):

  1. Assets are grouped by ticker symbol
  2. Priority ticker groups appear first in the order: BTC → KMD → ETH → BNB → LTC → DASH → ZEC → DOGE
  3. Remaining ticker groups are displayed alphabetically after priority groups

For authenticated users:

  • No changes - existing sorting logic remains unchanged (balance and priority-based sorting)
image

@DeckerSU
feat: implement priority sorting for unauthenticated user asset lists
a0cafd3 
- Added a set of priority ticker symbols for unauthenticated users.
- Implemented sorting logic in `sortAssetIdsWithPriority` to prioritize these tickers.
- Updated `AssetsList` to sort asset groups by priority tickers first, followed by others.
- Adjusted comments in `wallet_main.dart` to reflect the new sorting behavior.
@DeckerSU
refactor: remove unauthenticated user priority tickers and related so…
88eeb07 
…rting logic

- Deleted the set of priority ticker symbols for unauthenticated users.
- Removed the `sortAssetIdsWithPriority` function that utilized these tickers for sorting.
- Updated comments to reflect the removal of the priority sorting feature.
@DeckerSU
refactor: clean up coin_utils.dart by removing unused imports and sor…
10358e2 
…ting function
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch patch-assets-main-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit e961181):

https://walletrc--pull-3351-merge-dyu1919h.web.app

(expires Sun, 30 Nov 2025 08:06:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

smk762
smk762 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm functioning as explained. Coins to be included in this list may be up to debate, and modified in future, but this PR functionally adds the described changes.

@smk762 smk762 added this to the v0.9.4 milestone Nov 5, 2025
@smk762 smk762 merged commit dd1d2a4 into dev Nov 23, 2025
6 of 12 checks passed
@smk762 smk762 mentioned this pull request Nov 23, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smk762 smk762 smk762 approved these changes

@ca333 ca333 Awaiting requested review from ca333

@gcharang gcharang Awaiting requested review from gcharang

@CharlVS CharlVS Awaiting requested review from CharlVS

Assignees

@DeckerSU DeckerSU

Labels

None yet

Projects

None yet

Milestone

v0.9.4

Development

Successfully merging this pull request may close these issues.

2 participants

@DeckerSU @smk762