Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit ab91098): https://walletrc--pull-3308-merge-oz2nmy4w.web.app (expires Thu, 06 Nov 2025 11:35:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| final tx = Transaction( | ||
| id: result.txHash, | ||
| internalId: result.txHash, | ||
| assetId: state.asset.id, | ||
| balanceChanges: result.balanceChanges, | ||
| // Show as unconfirmed initially | ||
| timestamp: DateTime.fromMillisecondsSinceEpoch(0), | ||
| confirmations: 0, | ||
| blockHeight: 0, | ||
| from: state.selectedSourceAddress != null | ||
| ? [state.selectedSourceAddress!.address] | ||
| : <String>[], | ||
| to: [result.toAddress], | ||
| txHash: result.txHash, | ||
| fee: result.fee, | ||
| memo: state.memo, |
There was a problem hiding this comment.
Populate transaction amount for success details
The temporary Transaction shown after a successful withdrawal is built without an amount value, even though TransactionDetails renders the headline and USD conversion from transaction.amount. Because the field is never populated, the success screen will always display a zero amount regardless of what was actually sent. Use the confirmed withdrawal amount (e.g. from state.amount or by summing result.balanceChanges) when constructing tx so the details view shows the correct value.
Useful? React with 👍 / 👎.
Closes #3120
Shows details of a transaction after broadcast.
vokoscreenNG-2025-10-30_19-28-51.mp4
To test: