Skip to content

fix(layout): tablet layout navbars#2925

Merged
CharlVS merged 2 commits intodevfrom
codex/update-tablet-layout-navigation-bars
Jul 15, 2025
Merged

fix(layout): tablet layout navbars#2925
CharlVS merged 2 commits intodevfrom
codex/update-tablet-layout-navigation-bars

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Jul 15, 2025 •
edited
Loading

@smk762 Screenshot of the mobile, tablet and desktop layouts. This fixes an issue where the transition layout between desktop and mobile (tablet) was missing the top and bottom navbars. I've fixed it to use the mobile navbar (bottom) and the desktop app bar (top). Also note that the app bar is hidden on mobile when logged in to save vertical space (since its main purpose on mobile is for user to be able to sign in.

image image image

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CharlVS CharlVS changed the title refactor(layout): extract reusable top bar fix(layout): tablet layout navbars Jul 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 15, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 50d0bf6):

https://walletrc--pull-2925-merge-l1xkbijq.web.app

(expires Tue, 22 Jul 2025 16:27:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS requested a review from smk762 July 15, 2025 14:46
@CharlVS CharlVS self-assigned this Jul 15, 2025
@CharlVS CharlVS added the QA Ready for QA Testing label Jul 15, 2025
@CharlVS CharlVS added this to the v0.9.2 Release milestone Jul 15, 2025
@CharlVS CharlVS requested a review from mariocynicys July 15, 2025 16:23
mariocynicys
mariocynicys reviewed Jul 15, 2025
View reviewed changes
Copy link
Copy Markdown

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
LGTM :)

@CharlVS CharlVS merged commit a57be7b into dev Jul 15, 2025
9 of 13 checks passed
@CharlVS CharlVS deleted the codex/update-tablet-layout-navigation-bars branch July 15, 2025 16:38
@CharlVS CharlVS mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smk762 smk762 Awaiting requested review from smk762

1 more reviewer

@mariocynicys mariocynicys mariocynicys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CharlVS CharlVS

Labels

codex QA Ready for QA Testing

Projects

None yet

Milestone

v0.9.2 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@CharlVS @mariocynicys