linux: call XInitThreads() to make X11 access thread-safe by DeckerSU · Pull Request #2816 · GLEECBTC/gleec-wallet

DeckerSU · 2025-06-24T20:52:14Z

Flutter’s engine spawns multiple threads (UI, raster, etc.). Under X11 these threads may issue X calls concurrently, which is undefined unless XInitThreads() is invoked before the first X request.

Without this, the app aborts on launch with:

  [xcb] Unknown request in queue while dequeuing
  [xcb] Most likely this is a multi-threaded client and XInitThreads has not been called
  KomodoWallet: xcb_io.c:175: dequeue_pending_request: Assertion `!xcb_xlib_unknown_req_in_deq' failed.

This patch:

adds #include <X11/Xlib.h>
calls XInitThreads() at the very start of main() in linux/runner/main.cc
ensures libX11 is linked via CMake

Wayland sessions were already stable; this change fixes crashes when running under pure X11 or XWayland.

Flutter’s engine spawns multiple threads (UI, raster, etc.). Under X11 these threads may issue X calls concurrently, which is undefined unless XInitThreads() is invoked before the first X request. Without this, the app aborts on launch with: [xcb] Unknown request in queue while dequeuing [xcb] Most likely this is a multi-threaded client and XInitThreads has not been called KomodoWallet: xcb_io.c:175: dequeue_pending_request: Assertion `!xcb_xlib_unknown_req_in_deq' failed. This patch: * adds `#include <X11/Xlib.h>` * calls `XInitThreads()` at the very start of `main()` in `linux/runner/main.cc` * ensures libX11 is linked via CMake Wayland sessions were already stable; this change fixes crashes when running under pure X11 or XWayland. - flutter/flutter#170937 - flutter/flutter#169470

coderabbitai · 2025-06-24T20:52:35Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-24T20:56:04Z

Visit the preview URL for this PR (updated for commit e9c8ba2):

https://walletrc--pull-2816-merge-330w8asu.web.app

_{(expires Tue, 01 Jul 2025 20:55:55 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

CharlVS

Thank you so much for getting to the bottom of this.

smk762

Built and running on Ubuntu24 with XDG_SESSION_TYPE: x11 for over an hour without any stability issues.

smk762 self-requested a review June 25, 2025 00:09

CharlVS self-requested a review June 25, 2025 13:10

CharlVS approved these changes Jun 25, 2025

View reviewed changes

CharlVS added the QA Ready for QA Testing label Jun 25, 2025

smk762 mentioned this pull request Jun 26, 2025

Trezor default coins are non-segwit #2830

Closed

smk762 approved these changes Jun 26, 2025

View reviewed changes

CharlVS merged commit cea6755 into dev Jun 26, 2025
9 of 13 checks passed

CharlVS deleted the patch-linux-crash branch June 26, 2025 12:08

CharlVS mentioned this pull request Jul 31, 2025

chore(release): Komodo Wallet 0.9.2 Release #2850

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linux: call XInitThreads() to make X11 access thread-safe#2816

linux: call XInitThreads() to make X11 access thread-safe#2816
CharlVS merged 1 commit intodevfrom
patch-linux-crash

DeckerSU commented Jun 24, 2025

Uh oh!

coderabbitai Bot commented Jun 24, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions Bot commented Jun 24, 2025

Uh oh!

CharlVS left a comment

Uh oh!

smk762 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

DeckerSU commented Jun 24, 2025

Uh oh!

coderabbitai Bot commented Jun 24, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented Jun 24, 2025

Uh oh!

CharlVS left a comment

Choose a reason for hiding this comment

Uh oh!

smk762 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)