fix: resolve login failure with custom seed and improve withdraw form validation by CharlVS · Pull Request #2814 · GLEECBTC/gleec-wallet

CharlVS · 2025-06-23T15:35:27Z

🐛 Bug Fixes

Authentication & Login

Fix login failure when using custom seed phrases in HD wallet mode
Add proper error handling and user feedback for authentication failures
Display error messages via snackbars when wallet operations fail

Withdraw Form

Correct balance validation logic to use selected source address balance
Fix amount validation when switching between source addresses
Clear preview errors when toggling max amount option
Prevent unnecessary validation when max amount is enabled

🎨 UI/UX Improvements

Enhanced error messaging with proper styling and color schemes
Improved user feedback during wallet creation and import processes
Better visual feedback for loading states

🔧 Technical Changes

Added AuthBloc listeners to wallet creation and import widgets
Improved error state handling across wallet management components
Enhanced balance checking logic in withdraw form validation

📁 Files Modified

lib/bloc/withdraw_form/withdraw_form_bloc.dart - Balance validation fixes
lib/views/wallets_manager/widgets/iguana_wallets_manager.dart - Error handling
lib/views/wallets_manager/widgets/wallet_creation.dart - Auth error display
lib/views/wallets_manager/widgets/wallet_simple_import.dart - Import error handling
.gitignore - Added AGENTS_1.md to ignored files

🧪 Testing

Tested wallet creation with custom seeds
Verified withdraw form balance validation
Confirmed error message display functionality

📋 Type of Change

Fixes issues with custom seed authentication and improves overall wallet management user experience.

coderabbitai · 2025-06-23T15:35:34Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Fix bug where withdraw form would sometimes show the sum of all addresses as the max available instead of the selected address.

github-actions · 2025-06-24T16:44:02Z

Visit the preview URL for this PR (updated for commit 905d59d):

https://walletrc--pull-2814-merge-zjjhpfw7.web.app

_{(expires Fri, 11 Jul 2025 11:06:36 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

smk762

Import of existing non-BIP39 wallet file ✅
Creation of new non-BIP39 wallet login ✅
Meaningful and actionable error messages in login flow and validation ✅
Once imported / created, login flow for non-BIP39 wallets hides the HD mode toggle ✅

Withdraw form locked to pre-selected single address in disabled dropdown when in non-HD mode ✅

Slight issue with withdraw form validation in some cases.

This was after replacing bad address input with a pasted valid address. It seems the withdraw button remains in hiding until the red x at the right side of the destination address field is clicked.

PR is otherwise good - I can migrate the withdraw form bug to a new issue and approve if triage required.

CharlVS · 2025-06-30T16:25:31Z

@smk762 could you please give the wallet address validation another shot? I've pushed a fix.

…into ecf6xc-codex/fix-login-failure-with-custom-seed

smk762

LGTM, thanks!

fix(wallet): handle auth errors for custom seed

822a966

CharlVS added the codex label Jun 23, 2025 — with ChatGPT Codex Connector

fix: multi-address withdrawal max logic

8ea5b8b

Fix bug where withdraw form would sometimes show the sum of all addresses as the max available instead of the selected address.

CharlVS changed the title ~~fix: display auth errors on wallet restore~~ fix: auth/hd related bugs Jun 24, 2025

CharlVS changed the title ~~fix: auth/hd related bugs~~ fix: resolve login failure with custom seed and improve withdraw form validation Jun 24, 2025

chore: roll SDK packages

8c12fbc

CharlVS self-assigned this Jun 24, 2025

CharlVS added QA Ready for QA Testing bug Something isn't working and removed codex labels Jun 24, 2025

CharlVS added 2 commits June 24, 2025 18:48

fix(withdraw): auto-select source address (#2812)

6ebbc09

fix: show from withdraw field even for single address

02647c0

CharlVS requested review from smk762 June 26, 2025 12:09

smk762 requested changes Jun 27, 2025

View reviewed changes

fix: clear address error on input change (#2844)

806e185

Merge branch 'dev' of https://github.com/KomodoPlatform/komodo-wallet …

905d59d

…into ecf6xc-codex/fix-login-failure-with-custom-seed

smk762 approved these changes Jul 1, 2025

View reviewed changes

CharlVS closed this Jul 2, 2025

CharlVS deleted the ecf6xc-codex/fix-login-failure-with-custom-seed branch July 2, 2025 17:00

CharlVS restored the ecf6xc-codex/fix-login-failure-with-custom-seed branch July 4, 2025 11:02

CharlVS reopened this Jul 4, 2025

CharlVS merged commit 1600814 into dev Jul 8, 2025
16 of 24 checks passed

CharlVS deleted the ecf6xc-codex/fix-login-failure-with-custom-seed branch July 8, 2025 18:51

smk762 mentioned this pull request Jul 21, 2025

Legacy withdraw expects selection of single source address #2804

Closed

smk762 linked an issue Jul 22, 2025 that may be closed by this pull request

Legacy withdraw expects selection of single source address #2804

Closed

CharlVS mentioned this pull request Jul 31, 2025

chore(release): Komodo Wallet 0.9.2 Release #2850

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve login failure with custom seed and improve withdraw form validation#2814

fix: resolve login failure with custom seed and improve withdraw form validation#2814
CharlVS merged 7 commits intodevfrom
ecf6xc-codex/fix-login-failure-with-custom-seed

CharlVS commented Jun 23, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 23, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions Bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

smk762 left a comment

Uh oh!

CharlVS commented Jun 30, 2025 •

edited

Loading

Uh oh!

smk762 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

CharlVS commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🐛 Bug Fixes

🎨 UI/UX Improvements

🔧 Technical Changes

📁 Files Modified

🧪 Testing

📋 Type of Change

Uh oh!

coderabbitai Bot commented Jun 23, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smk762 left a comment

Choose a reason for hiding this comment

Uh oh!

CharlVS commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smk762 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CharlVS commented Jun 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented Jun 24, 2025 •

edited

Loading

CharlVS commented Jun 30, 2025 •

edited

Loading