Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Visit the preview URL for this PR (updated for commit 84a016e):

https://walletrc--pull-2750-merge-24g546se.web.app

_{(expires Fri, 18 Jul 2025 14:54:41 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

I've hit a possible edge case with this one. Not sure yet if easily reproducible or if pre-requisite steps are relevant but here is goes anyway:

• Login, activate and deactivate a few coins at random. Make sure to deactivate a parent coin, but keep one of its tokens (e.g. I disabled MATIC, kept 1INCH-PLG20)
• logout, login.
• try to activate coins. They disappear from the "activate" list, but do not appear on the "portfolio" list.

No logs were identified which held any information that appeared to be related to this.

Upon logging out and then back in again, all the previously selected coins which were hanging out with the cat of Dr Schrödinger appeared without problem. After disabling half of them, I logged out/in again, and the selection was preserved.

Attempting again to replicate the problem, I disabled MATIC but left 1INCH-PLG20 active. After L.I/O again, this was preserved - MATIC not in portfolio, but 1INCH-PLG20 was.

This is an unnatural state, as I dont understand how it was actually activated when running the token activation methods without parent coin active will return

{
    "mmrpc": "2.0",
    "error": "Platform coin MATIC is not activated",
    "error_path": "token.lp_coins",
    "error_trace": "token:136] lp_coins:5032]",
    "error_type": "PlatformCoinIsNotActivated",
    "error_data": "MATIC",
    "id": null
}

This time around, I was able to activate and deactivate coins as expected, though MATIC ended up something went wrong with a flickering fiat text (at zero, though I am funded) and selected list preservation was degraded.

tl;dr, this works in perfect conditions, but the edge cases as close as walking the plank.

Please recheck the parent/token logics. In legacy desktop, attempts to disable a parent would prompt a pop up to appear threatening to kill its children too unless the parent remains abled.

I've confirmed that attempting to disable parent shows pop up listing the child tokens which will also be disabled.
From here, cancel or confirm both act as expected.

Next test was to check the case where an attempt is made to disable a token while active swap is in progress, or order is open, then do the same again for a parent coin while a child was in the middle of a swap. I was unable to progress this far, as the following error presented.

I subsequently confirmed that MATIC is indeed active, and its wallet page shows balance / addresses / history as expected from an active coin. Attempting a BEP20 token swap led to the same outcome.

For reference, if not yet implemented (or towards a separate issue), this should be the flow when disabling during swap:

• If token / stand alone coin, it should not be possible to disable the coin while it has a swap in progress.
• If a parent coin, as above, along with the constraint extending to cover child tokens.
• If an order is open for parent / token to be disabled, a pop up warning to indicate order(s) are open, along with the option to cancel these orders alongside the coin/token.

Test cases passed after most recent changes:

• Disabling coin works and persists after logging out and back in again.
• Disabling parent shows popup listing child tokens.
• Disabling parent disables children as well.
• Disabling parent is permanent (does not re-appear, persists through logout/login cycle).
• Disabling coin with open maker order shows popup warning.
• Disabling coin with open maker order cancels the order.
• Disabling parent coin with open maker order cancels the order, disables parent, and disables children.
• Disabling coin with active swap shows a popup warning and does not allow the user to proceed