Skip to content

HD Address Management & Seed Import#2510

Merged
CharlVS merged 35 commits intodevfrom
hd-seed-import
Jan 27, 2025
Merged

HD Address Management & Seed Import#2510
CharlVS merged 35 commits intodevfrom
hd-seed-import

Conversation

@naezith
Copy link
Copy Markdown
Collaborator

@naezith naezith commented Jan 13, 2025 •
edited by CharlVS
Loading

Replaced with comment by @CharlVS. See the comment version history for the original version.

HD Address Management & Seed Import

This PR is the first milestone for HD wallet integration, focusing on HD seed import and address generation. The remaining integration PRs will follow soon.

QA:

Please test the following functionality:

  1. Seed import and export (HD and non-HD with bip39 and non-bip39 seed)
  2. Switching between HD and non-HD mode
  3. Address generation: Multiple addresses are allowed in HD mode and disabled in non-HD mode. Check that re-importing the seed yields the same addresses.

For Devs:

This also adds WalletType.hdwallet; please review the implementation. It's not listed in the connect list like other WalletType entries so there's some custom code around that.

Please test deeply.

General

Screenshots of seed import:

Screenshots of address management:

MIA

naezith and others added 30 commits January 13, 2025 19:02
@naezith
seed import hd switch
7b92318
@naezith
seed import hdw switch separate widget
fe3439b
@naezith
seed import hd mode toggle at login
25ae495
@takenagain @naezith
improve login activated coins metadata storing
0b6798f
@naezith
seed import hd toggle for create wallet
98f88ce
@naezith
seed import hd wallet switch localization
05097d6
@naezith
Merge branch 'merge/hd-coin-details' into feature/hd-seed-import
5da2a26
@naezith
seed import hd wallet switch smaller subtitle text
a84b1db
@naezith
seed import adjust spacing
6387d5c
@naezith
sdk fix download seed downloads empty seed
8e28191
@naezith
seed import hd toggle for seed file import
d998ab6
@naezith
seed import single checkbox for both eula & tos
7c83cc9
@naezith
seed import visible allow custom seed checkbox
2d3a279
@naezith
ui checkbox align left and accept Text widget
3c551fb
@naezith
seed import single text eula tos inside checkbox
ff12280
@naezith
upgrade sdk
00e7e5d
@naezith
Merge branch 'merge/hd-coin-details' into feature/hd-seed-import
0012f77
@naezith
localization fix Terms & Conditions
89f0117
@naezith
seed import reuse code
be1e0e8
@naezith
localization tweak walletImportByFileDescription
ac9a8f0
@naezith
seed import tweak file import page layout
17f05e4
@naezith
seed import CustomSeedCheckbox widget
37e5fe0
@naezith
seed import by file page eula tos checkbox
3b094c9
@naezith
seed import by file page custom seed checkbox
fbc7416
@naezith
ui checkbox text flexible instead of expanded
f812734
@naezith
seed import disallow custom seed if hd wallet
689fb8c
@naezith
wallet login hide hd mode if not isBip39Seed
47c1b59
@naezith
seed import uppercase OR divider
e78d519
@naezith
seed import eula checkbox link styling
c916471
@naezith
seed import file disallow custom seed if hd wallet
61afa86
@naezith naezith requested review from CharlVS and ca333 January 13, 2025 16:43
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 13, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 4dbf30a):

https://walletrc--pull-2510-merge-lzsdoti4.web.app

(expires Tue, 28 Jan 2025 09:03:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

CharlVS
CharlVS reviewed Jan 14, 2025
View reviewed changes
Comment thread lib/model/wallet.dart Outdated
Comment thread lib/views/wallets_manager/widgets/wallet_import_by_file.dart Outdated
@CharlVS CharlVS added the QA Ready for QA Testing label Jan 14, 2025
@CharlVS CharlVS changed the title HD Seed Import HD Address Management & Seed Import Jan 14, 2025
@CharlVS CharlVS requested review from AndrewDelaney and smk762 and removed request for ca333 January 14, 2025 15:43
@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented Jan 15, 2025

  • confirmed non-BIP39 seed import from file rejected if HD mode selected, or I understand not input.
  • confirm no regression when attempting wallet import with same as existing name
  • confirm import of 24 word seed via input in HD mode functions as expected.
  • Error seen in tx history panel something went wrong when zero balance. Once funded, functioning as expected.
  • Error seen when clicking on wallet>receive button
    image
  • HD addresses list shows balances, but combined balance still zero
    Screenshot from 2025-01-15 14-24-25
  • KMD rewards claim button leads to endless spinner and error in console logs
    image
  • Address creation and "hide addresses with zero balance" functioning as expected.

Other errors seen in console logs:
image

ShantanuSharma9873
ShantanuSharma9873 reviewed Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown

@ShantanuSharma9873 ShantanuSharma9873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR, and here are my observations from the smoke testing:

  • Successfully created a new wallet in both modes: With HD Wallet and Without HD Wallet.
  • Successfully saved the seed phrase and downloaded the seed file.

HD Wallet 1
HD Wallet 2

Non-HD Wallet Mode:

  • The "Create Address" button was disabled.
  • Hovering over the button displayed the tooltip: "Current wallet mode does not support multiple addresses."

HD Wallet Mode:

  • Successfully created multiple addresses for a single coin.
  • Verified that the addresses could be copied and their QR codes were accessible.

Additional Observations:
Wallet Name Missing:

Seed File Import Issue:

The testing is still left to be completed.

@CharlVS CharlVS mentioned this pull request Jan 27, 2025
Closed
@CharlVS
Copy link
Copy Markdown
Collaborator

CharlVS commented Jan 27, 2025

Thank you for your thorough review, @ShantanuSharma9873. Please continue any further findings here: #2516

@CharlVS CharlVS merged commit 3b40883 into dev Jan 27, 2025
@CharlVS CharlVS mentioned this pull request May 23, 2025
Merged
@CharlVS CharlVS deleted the hd-seed-import branch June 20, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CharlVS CharlVS CharlVS left review comments

@smk762 smk762 Awaiting requested review from smk762

@AndrewDelaney AndrewDelaney Awaiting requested review from AndrewDelaney

+1 more reviewer

@ShantanuSharma9873 ShantanuSharma9873 ShantanuSharma9873 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@CharlVS CharlVS

Labels

QA Ready for QA Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@naezith @smk762 @CharlVS @ShantanuSharma9873 @takenagain