Upgrade Arrow C++ to 24.0.0#647
Merged
Merged
Conversation
Contributor
Author
|
The benchmark project is reliably segfaulting. I have a minimal repro here: https://github.com/adamreeve/ParquetSharp/blob/segfault-repro/SegfaultRepro/Program.cs Looks like it's related to mimalloc and only happens when writing Parquet from multiple threads (but doesn't need any concurrency). Backtrace is: DetailsThe repro works fine if setting The current mimalloc version after updating the vcpkg baseline is 3.3.1. In the previous 23.0.0 release of ParquetSharp, mimalloc 3.2.7 was used. I tested downgrading mimalloc to 3.2.7 and that works, so I think we should just pin mimalloc to the older version for now and report this upstream (ideally with a repro that just uses mimalloc directly from C++). Edit: mimalloc 3.2.8 also works so I've pinned to that. The first broken version is 3.3.0, and 3.3.2 is also broken. |
marcin-krystianc
previously approved these changes
May 4, 2026
adamreeve
commented
May 4, 2026
Comment on lines
+124
to
+126
| curl -L -o /tmp/bison-${BISON_VERSION}.tar.gz https://ftp.gnu.org/gnu/bison/bison-${BISON_VERSION}.tar.gz && | ||
| tar -xf /tmp/bison-${BISON_VERSION}.tar.gz -C /tmp && | ||
| cd /tmp/bison-${BISON_VERSION} && ./configure && make && make install" |
Contributor
Author
There was a problem hiding this comment.
This is a bit slow, and we could instead use the bison-bin PyPI package (https://github.com/trim21/bison-py), but I don't think this is widely used enough that we should trust it, and it's hard to verify the wheel contents.
Maybe we should be building a docker image that we can cache instead, but that feels like it should be a separate PR.
marcin-krystianc
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.