fix: only use Reference as the commit if it does not have a dot for Packagist packages#342
Merged
fix: only use Reference as the commit if it does not have a dot for Packagist packages#342
Conversation
…ackagist packages
b2baa0e to
049b818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its possible for the
referencefield to contain values other than commits, such as for Drupal packages it holds a tag-type value.Because I'm not sure all of the details behind when this will be the case, I've gone with having us blank the commit if the value has a dot in it since that is not a valid character in a SHA anyway, but this might not cover all situations e.g. if a branch-type value could be used.
This is cherry-picked from google/osv-scalibr#958