Skip to content

refactor(semantic): remove unneeded logic in parsing semver-like versions#277

Merged
G-Rath merged 1 commit intomainfrom
semantic/remove-unneeded-logic
Oct 31, 2024
Merged

refactor(semantic): remove unneeded logic in parsing semver-like versions#277
G-Rath merged 1 commit intomainfrom
semantic/remove-unneeded-logic

Conversation

@G-Rath
Copy link
Owner

@G-Rath G-Rath commented Oct 31, 2024

While I'm a little reluctant to do this as I'm sure I included these for a reason, they're apparently not covered by any tests and the longer they remain the more likely someone might start actually depending on them.

I'm pretty sure the bulk of this was present as part of having semantic rebuild the parsed version for debugging when I was writing the implementation, but that's not actually a feature so we don't explicitly need to be doing it - this won't stop us from reintroducing the logic in future if we decide we want it

@G-Rath G-Rath merged commit 674b62d into main Oct 31, 2024
@G-Rath G-Rath deleted the semantic/remove-unneeded-logic branch October 31, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant