Skip to content

fix: Fix App after Compile#65

Merged
im-coder-lg merged 4 commits intomasterfrom
fix-build
Jan 26, 2022
Merged

fix: Fix App after Compile#65
im-coder-lg merged 4 commits intomasterfrom
fix-build

Conversation

@sumeshir26
Copy link
Copy Markdown
Member

@sumeshir26 sumeshir26 commented Jan 25, 2022

Issue fixed! Caused by darkdetect!

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 25, 2022 •
edited
Loading

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: 081e301

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61ef8de8028fc10008cfd821

@sumeshir26
Copy link
Copy Markdown
Member Author

sumeshir26 commented Jan 25, 2022

To apply change, Unistall the current installation of TimerX before building the new MSI

@not-nef not-nef mentioned this pull request Jan 25, 2022
Merged
not-nef
not-nef previously approved these changes Jan 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@not-nef not-nef left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Still have to do some work (Disable "System" option and lokk into why the blur isnt working) but its a good start. When do you want to release?

@sumeshir26 sumeshir26 requested a review from not-nef January 25, 2022 05:47
@sumeshir26
Copy link
Copy Markdown
Member Author

sumeshir26 commented Jan 25, 2022

@not-nef Check out my new changes

@sumeshir26
Copy link
Copy Markdown
Member Author

sumeshir26 commented Jan 25, 2022

It would be nice if the release is out by tomorrow.

Also did you notice that when you switch the theme to dark and restart, the transperency gets lowered to minimum

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 25, 2022

Also did you notice that when you switch the theme to dark and restart, the transperency gets lowered to minimum

Same here.

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 25, 2022

I'll start work on the release notes. If we make it better, it might mean more users.

@sumeshir26 sumeshir26 linked an issue Jan 25, 2022 that may be closed by this pull request
Theme doesn't load #64
Closed
@sumeshir26 sumeshir26 added ready Ready for merge. bug Something isn't working high priority labels Jan 25, 2022
@sumeshir26
Copy link
Copy Markdown
Member Author

sumeshir26 commented Jan 25, 2022

@TimerX-App/reviewers Can you please review? I want to get this merged ASAP

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 25, 2022

I will do it soon, maybe within 10 minutes! I need to remove every single installation of TimerX, so you'll have to wait.

im-coder-lg
im-coder-lg approved these changes Jan 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Works on my PC.

@sumeshir26
Copy link
Copy Markdown
Member Author

sumeshir26 commented Jan 25, 2022

@not-nef approve this

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 25, 2022

I think he's at school right now. Wait for some time.

@im-coder-lg im-coder-lg mentioned this pull request Jan 25, 2022
Merged
@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 26, 2022

@sumeshir26 I'll just tell, you merge this now. @not-nef seems to be busy, so you merge this. I am almost done on the release notes, will be complete by 9:30 AM IST. You trigger the all-build release action now.

@sumeshir26
Copy link
Copy Markdown
Member Author

sumeshir26 commented Jan 26, 2022

Can you merge both PRs and trigger? You cant trigger actions from GH Mobile

@im-coder-lg im-coder-lg merged commit c395499 into master Jan 26, 2022
@im-coder-lg im-coder-lg deleted the fix-build branch January 26, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@im-coder-lg im-coder-lg im-coder-lg approved these changes

@not-nef not-nef Awaiting requested review from not-nef

Assignees

No one assigned

Labels

bug Something isn't working high priority ready Ready for merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Theme doesn't load

3 participants

@sumeshir26 @im-coder-lg @not-nef