Skip to content

docs: Adhere to new org change#48

Merged
sumeshir26 merged 1 commit intomasterfrom
upd-docs
Jan 17, 2022
Merged

docs: Adhere to new org change#48
sumeshir26 merged 1 commit intomasterfrom
upd-docs

Conversation

@im-coder-lg
Copy link
Copy Markdown
Member

@im-coder-lg im-coder-lg commented Jan 15, 2022

Changing the docs. I also must add a PR template soon. If there are other links to be changed, tell the website path and I'll fix it!

@im-coder-lg im-coder-lg added the documentation Improvements or additions to documentation label Jan 15, 2022
@im-coder-lg im-coder-lg self-assigned this Jan 15, 2022
@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 15, 2022

Also - don't forget to add yourself to the review team, it would auto-assign(idk how).

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 15, 2022

Why's Netlify not working?

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 15, 2022

Yup, Netlify isn't integrated yet. @sumeshir26 it's the same way you started the deployment but when you are going to choose the Git repo from GitHub, click your account name near the repo search bar. Then, click "Add an org" and link this org via the Netlify app. Then choose this repo and deploy.

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 15, 2022

Why do macos checks fail for everything?

@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 15, 2022

Not sure. Let me look into it

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 15, 2022

Not sure. Let me look into it

Found it, you have to include utils.py in setup.py @sumeshir26

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 15, 2022

i was never a fan of python projects with more than one script

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 15, 2022

I cant fix it rn, im on the go

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 15, 2022

Fixed!

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 15, 2022

Lmao macos checks still fail

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 15, 2022

Yeah... I will inspect that later.

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 15, 2022

Please just drop macos support it just brings issues!!

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 16, 2022 •
edited
Loading

Maybe, that seems a really viable option. We could request users to use the Wine compatibility layer. I will research on that and make a documentation page for it by tomorrow in this PR.

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 16, 2022

Thank you 🙏

sumeshir26
sumeshir26 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sumeshir26 sumeshir26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumeshir26 sumeshir26 merged commit d6ddf01 into master Jan 17, 2022
@sumeshir26 sumeshir26 deleted the upd-docs branch January 17, 2022 04:54
@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 17, 2022

Uhm... I was about to add some other changes... I'll commit it directly later.

@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 17, 2022

Sorry!

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 17, 2022

It's fine, I'll directly commit.

@not-nef
Copy link
Copy Markdown
Member

not-nef commented Jan 17, 2022

Uhm... I was about to add some other changes...

Thats why drafts exist lmao

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 17, 2022

I was a bit lazy and overconfident. School started again lol. I will try improving my Gitpod experience, it's hard for me to make PRs all the time. @sumeshir26 can you enable Netlify again?

@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 17, 2022 •
edited
Loading

I did that! timerx-app.netlify.app

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 17, 2022

Domain failed... Check Netlify!

@im-coder-lg
Copy link
Copy Markdown
Member Author

im-coder-lg commented Jan 17, 2022

Make sure to change the Git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumeshir26 sumeshir26 sumeshir26 approved these changes

@not-nef not-nef not-nef approved these changes

Assignees

@im-coder-lg im-coder-lg

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@im-coder-lg @not-nef @sumeshir26