feat: Dynamic Resizing#40
feat: Dynamic Resizing#40sumeshir26 merged 10 commits intoFutura-Py:masterfrom not-nef:Dynamic-Resize
Conversation
im-coder-lg
left a comment
There was a problem hiding this comment.
Is this totally ready for merge?
|
@not-nef @im-coder-lg Wait, there are some things I want to add |
|
Phew! I didn't approve easily, since if it's done in one go, there has to be something else to add, right? |
|
Also, from now, the best way of committing is from the CLI, use this method: $ pip install -r requirements-dev.txt # get pre-commit hooks and commitizen
$ pre-commit install
$ git add . # adds everything
$ cz commit
add anything, type of commit, scope(optional), title, description, if it's a breaking change or not, why, etc.
$ git pushThe best method by a mile. |
ok, just tell me what it is and i add it |
|
✔️ Deploy Preview for timerx-app canceled. 🔨 Explore the source changes: eb714c8 🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61dd2b1a2946fc0007b565c3 |
|
@sumeshir26 will tell that, also why is Netlify failing? |
|
I knew(expected) it! We need to change the base folder to |
|
Well can someone pls tell me what to add fgs |
|
Is it possible to just change the width of the buttons using .configure(width=)? |
|
Well, you can do that, but afaik the width parameter adjusts the width and not the general size of the Button. |
|
So it makes the button wider |
|
I know, but still that’s better than nothing |
|
okay, will do that later this day |
recordedVideo2022-01-09-144147_Trim.mp4 |
|
@sumeshir26 @im-coder-lg pls review |
|
Excellent! Anything else to add? |
|
Nope, all done |
|
WOOO 🎉🎉🎉 |
|
Wait, can you run |
Don't blame me, Vivaldi Mail was fast. |
|
whats vivaldi mail |
|
My mail client on my browser. It's Vivaldi, kinda like resource-hogging for me tho. |
|
@sumeshir26 merge? |
|
btw school start again tomorrow (for me) so i will have less time to work on TimerX. :( |
|
I know, same for me. I'm a teenager too lol. But I can manage school, it's
not _too_ hard. Maybe I'll be committing some files during my soon-to-come
holidays. But don't worry - I'll try fixing some things and try some crazy
Tk things that might end up as a new feature. Maybe I'll start with editing
the About page since the TimerX text is too large.
Also, I never provided the gist of the app text, so maybe now's the chance for me to make sure I learn something new.
|
|
and @sumeshir26 this time, pls use this commit message. So it doesnt list all commits |
|
I'll just rename the PR? That'd be easier, right? |
Actually, it's the merge description. |
nah, i just dont want that all commits are listed in the master branch commit |
See, we squash and merge, meaning everything is made into one commit. The merge description would have the commit list. |
Well it doesnt go good for me. Since the start of 8th class ive been a complete E Student and it doesnt seem to get better. Before, i was pretty average. I have a chemistry exam on wednesday and if my grades dont get better i wont make the year. :( |
|
Well, all the best, hope you do well! |
|
Well, let's try this. Till you return back on Thursday, well just update the documentation and/or add very minor features related to build. I will just edit the about page, minor change. After you are back, we'll resume. I think this is needed since you are the person with the most Python-related commits(even @sumeshir26 is, but for me, you are more creative than me in regards to Python). I think this is the best way for us to say thank you. Make sure you are well-prepared for that exam and just finish that up! All the best too :) |
|
Thank you so much ❤️ |
|
I think we will start with merging this PR and then start updating documentation from #42 till Thursday. |
Good Luck, hope it goes good for you! |
|
Build fails :\ btw saw this come as mail, I'm still busy |
|
Wait what? the build fails! |
|
@im-coder-lg No, that was because of an updated workflow file on |
|
Build failed in PR checks, can you please verify?
|
|
Oh, okay. I must've done the same on the PR too.
|
recordedVideo2022-01-07-132853_Trim.mp4