Skip to content

feat: Dynamic Resizing#40

Merged
sumeshir26 merged 10 commits intoFutura-Py:masterfrom
not-nef:Dynamic-Resize
Jan 11, 2022
Merged

feat: Dynamic Resizing#40
sumeshir26 merged 10 commits intoFutura-Py:masterfrom
not-nef:Dynamic-Resize

Conversation

@not-nef
Copy link
Copy Markdown
Member

@not-nef not-nef commented Jan 7, 2022

recordedVideo2022-01-07-132853_Trim.mp4

@not-nef not-nef added the ready Ready for merge. label Jan 7, 2022
Copy link
Copy Markdown
Member

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this totally ready for merge?

@sumeshir26
Copy link
Copy Markdown
Member

@not-nef @im-coder-lg Wait, there are some things I want to add

@im-coder-lg
Copy link
Copy Markdown
Member

Phew! I didn't approve easily, since if it's done in one go, there has to be something else to add, right?

@sumeshir26 sumeshir26 requested a review from im-coder-lg January 8, 2022 03:24
@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 8, 2022

Also, from now, the best way of committing is from the CLI, use this method:

$ pip install -r requirements-dev.txt # get pre-commit hooks and commitizen
$ pre-commit install
$ git add . # adds everything
$ cz commit
add anything, type of commit, scope(optional), title, description, if it's a breaking change or not, why, etc.
$ git push

The best method by a mile.

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 8, 2022

@not-nef @im-coder-lg Wait, there are some things I want to add

ok, just tell me what it is and i add it

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 8, 2022

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: eb714c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61dd2b1a2946fc0007b565c3

@im-coder-lg
Copy link
Copy Markdown
Member

@sumeshir26 will tell that, also why is Netlify failing?

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 8, 2022

I knew(expected) it! We need to change the base folder to docs.

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 8, 2022

Well can someone pls tell me what to add fgs

@sumeshir26
Copy link
Copy Markdown
Member

Is it possible to just change the width of the buttons using .configure(width=)?

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

Well, you can do that, but afaik the width parameter adjusts the width and not the general size of the Button.

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

So it makes the button wider

@sumeshir26
Copy link
Copy Markdown
Member

I know, but still that’s better than nothing

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

okay, will do that later this day

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

recordedVideo2022-01-09-144147_Trim.mp4

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

@sumeshir26 @im-coder-lg pls review

@im-coder-lg
Copy link
Copy Markdown
Member

Excellent! Anything else to add?

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

Nope, all done

Copy link
Copy Markdown
Member

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

WOOO 🎉🎉🎉

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 9, 2022

Wait, can you run isort(available on PyPI)? Just to sort the imports, stack them properly. If not, leave it, it might happen accidentally soon.

@im-coder-lg
Copy link
Copy Markdown
Member

wtf how fast was that

Don't blame me, Vivaldi Mail was fast.

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

whats vivaldi mail

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 9, 2022

My mail client on my browser. It's Vivaldi, kinda like resource-hogging for me tho.

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

@sumeshir26 merge?

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

btw school start again tomorrow (for me) so i will have less time to work on TimerX.

:(

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 9, 2022 via email

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

and @sumeshir26 this time, pls use this commit message.

feat: Dynamic resizing (#40)

So it doesnt list all commits

@im-coder-lg
Copy link
Copy Markdown
Member

I'll just rename the PR? That'd be easier, right?

@im-coder-lg
Copy link
Copy Markdown
Member

So it doesnt list all commits

Actually, it's the merge description.

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

I'll just rename the PR? That'd be easier, right?

nah, i just dont want that all commits are listed in the master branch commit

@im-coder-lg
Copy link
Copy Markdown
Member

Nah, i just don't want that all commits are listed in the master branch commit

See, we squash and merge, meaning everything is made into one commit. The merge description would have the commit list.

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

I know, same for me. I'm a teenager too lol. But I can manage school, it's not too hard. Maybe I'll be committing some files during my soon-to-come holidays. But don't worry - I'll try fixing some things and try some crazy Tk things that might end up as a new feature. Maybe I'll start with editing the About page since the TimerX text is too large. Also, I never provided the gist of the app text, so maybe now's the chance for me to make sure I learn something new.

Well it doesnt go good for me. Since the start of 8th class ive been a complete E Student and it doesnt seem to get better. Before, i was pretty average. I have a chemistry exam on wednesday and if my grades dont get better i wont make the year. :(

@im-coder-lg
Copy link
Copy Markdown
Member

Well, all the best, hope you do well!

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 9, 2022

Well, let's try this. Till you return back on Thursday, well just update the documentation and/or add very minor features related to build. I will just edit the about page, minor change. After you are back, we'll resume. I think this is needed since you are the person with the most Python-related commits(even @sumeshir26 is, but for me, you are more creative than me in regards to Python). I think this is the best way for us to say thank you. Make sure you are well-prepared for that exam and just finish that up! All the best too :)

@not-nef
Copy link
Copy Markdown
Member Author

not-nef commented Jan 9, 2022

Thank you so much ❤️

@im-coder-lg
Copy link
Copy Markdown
Member

I think we will start with merging this PR and then start updating documentation from #42 till Thursday.

@sumeshir26
Copy link
Copy Markdown
Member

Well it doesnt go good for me. Since the start of 8th class ive been a complete E Student and it doesnt seem to get better. Before, i was pretty average. I have a chemistry exam on wednesday and if my grades dont get better i wont make the year. :(

Good Luck, hope it goes good for you!

@sumeshir26 sumeshir26 changed the title Dynamic Resize feat: Dynamic Resizing Jan 11, 2022
@im-coder-lg
Copy link
Copy Markdown
Member

Build fails :\ btw saw this come as mail, I'm still busy

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 11, 2022

Wait what? the build fails!

@sumeshir26 sumeshir26 merged commit 79f99f4 into Futura-Py:master Jan 11, 2022
@sumeshir26
Copy link
Copy Markdown
Member

sumeshir26 commented Jan 11, 2022

@im-coder-lg No, that was because of an updated workflow file on sumeshir26:master

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 11, 2022 via email

@im-coder-lg
Copy link
Copy Markdown
Member

im-coder-lg commented Jan 11, 2022 via email

@not-nef not-nef deleted the Dynamic-Resize branch January 11, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Ready for merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants