Settings window#25
Conversation
|
Woah, is that Windows 11? Cool! |
|
Also, too much of additions, wonder if we could merge this... |
wdym too much additions? |
|
could you replace the current dark theme bhutton with the settings one? |
sure |
|
Here are the things that should be added to the settings window
|
|
TODOS:
|
|
|
@sumeshir26 wdym json and yaml setting saving? i just did it with a text file. |
|
Then we need to have like 10 text files. You can do it woth txt files, I will migrate to Json afterwards |
|
just tell me how to do it |
This doesn't seem to work on my Windows 7 PC as well as my Raspberry Pi running Ubuntu Impish. Need to inspect this. |
Let's use YAML, it doesn't have a lot of curly braces that confuse me. |
|
now button texture syncs |
|
i will continue tomorrow |
Icons also sync correctly now. I also replaced the „switch themes“ Button with the settings button
|
Makin Progress :) |
|
Great work so far! |
|
btw @sumeshir26 we can do it with one text file if we only read specific lines, so you dont have to migrate it. |
|
Okay, do it how you think is best... |
|
thx |
|
bro this took ages |
|
@sumeshir26 what transparency do you mean? |
|
Hey I'm back, need to test this soon. Can I change the base branch to the |
|
I can't explain tho, feeling blank on the branch change. Maybe not. |
|
@im-coder-lg i would keep it like it is and then merge it in the master branch when its done. |
|
ive found a fix! |
|
oh, yep thats the one i found |
|
@not-nef Can you give me collaborator access to your fork? |
Added option to show notification, keep app on top, and added icons and descriptions for every setting
|
@sumeshir26 gave you acces, but this pr is ready for merging |
|
Bro remove configurator.py from setup.py!!! cx_Freeze is failing! |
|
I'll commit that |
|
Fixed. |
|
how did you commit? |
There was a problem hiding this comment.
I finally declare LGTM! Congrats @not-nef! Also thanks for this!
|
np, this was a fun journey! |
|
@sumeshir26 merge? |
Collaborator access you gave me. It was of real value. |
yeah too fun
On New Year. That'd make it crazily special. We'd better merge #26 too, a lot of additions that's why. |
|
coolio, gettin pretty close to 1.0 right? |
|
Actually, it's 0.9 right now but it might change anytime! |
|
@not-nef Can you share a final screenshot? |
|
|
@not-nef Thank You! |
|
LETS GOOO |
|
@sumeshir26 is there some way to apply for collaborator acces? |
|
Only the maintainer can give collaborator access. But you have to be careful, 'cause you might end up doing some mistakes, that's why I use PRs for new things on the website and immediate commits to fix simple things like CI/CD. |
|
i would use prs too but it would be cool to have collaborator acces for things like #28 |

THIS PR IS NOT READY FOR MERGING, its just for progress tracking.
Check this out:
: