Skip to content

feat: add flag "output file"#137

Merged
Fubukimaru merged 10 commits into
masterfrom
iss132
Nov 17, 2024
Merged

feat: add flag "output file"#137
Fubukimaru merged 10 commits into
masterfrom
iss132

Conversation

@Fubukimaru

@Fubukimaru Fubukimaru commented Nov 17, 2024

Copy link
Copy Markdown
Owner

We now have a -o flag for the output. You can:

  • Modify your file output (like what happens using .FILENAME)
  • Put the output in a folder
  • Both

Closes #132

@duhow duhow self-requested a review November 17, 2024 11:54
duhow
duhow reviewed Nov 17, 2024
View reviewed changes
Comment thread src/dura.y Outdated
duhow
duhow reviewed Nov 17, 2024
View reviewed changes
Comment thread src/dura.y Outdated
duhow
duhow reviewed Nov 17, 2024
View reviewed changes
Comment thread test/features/program.feature
duhow
duhow reviewed Nov 17, 2024
View reviewed changes
Comment thread test/steps/build.py Outdated
duhow
duhow reviewed Nov 17, 2024
View reviewed changes
Comment thread test/steps/build.py Outdated
@duhow duhow changed the title Iss132 - Added -o flag feat: add flag "output file" Nov 17, 2024
Fubukimaru and others added 3 commits November 17, 2024 14:11
@Fubukimaru @duhow
Update src/dura.y
a7b3b60 
La pitón

Co-authored-by: David Girón <contacto@duhowpi.net>
@Fubukimaru @duhow
Update src/dura.y
a995179 
chore: Syntax help message clearer.

Co-authored-by: David Girón <contacto@duhowpi.net>
@Fubukimaru @duhow
Update test/steps/build.py
7345d71 
chore: cleaned code comment.

Co-authored-by: David Girón <contacto@duhowpi.net>
duhow
duhow reviewed Nov 17, 2024
View reviewed changes
Comment thread test/steps/build.py Outdated
Fubukimaru and others added 2 commits November 17, 2024 14:25
@Fubukimaru
feat: Added tests for .FILENAME pseudo-instruction
e0712ba
@Fubukimaru @duhow
Update test/steps/build.py
07fdd9e 
feat: Tests now use flag as the whole flags to be sent. With this the testing is more flexible.

Co-authored-by: David Girón <contacto@duhowpi.net>
duhow
duhow reviewed Nov 17, 2024
View reviewed changes
Comment thread test/steps/build.py Outdated
@Fubukimaru Fubukimaru merged commit 194e3c5 into master Nov 17, 2024
@Fubukimaru Fubukimaru deleted the iss132 branch November 17, 2024 21:28
@jksigtermans

jksigtermans commented Apr 19, 2026

Copy link
Copy Markdown

Output file flag not functioning as expected on Ubuntu x86_64 (asmsx-linux-x86_64).
Using:
asmsx src/main.asm -o build/main.rom

Output:

Building MSX ROM...

asMSX v1.2.0 MSX cross-assembler. asMSX Team. [2026-02-26]

Redefining output name (Overrides .FILENAME): /home/fozzie/Tmp/openmsx-project/build/main.rom
Using custom output path: /home/fozzie/Tmp/openmsx-project/build/main.rom
Fatal: cannot open /home/fozzie/Tmp/openmsx-project/build/main.rom

strace -e openat asmsx src/main.asm -o build/main.rom
...Results in:
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib/x86_64-linux-gnu/libm.so.6", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3

@duhow

duhow commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Does the folder build exist and has permission to write?

@jksigtermans

jksigtermans commented Apr 20, 2026

Copy link
Copy Markdown

The folder exists, the permissions are: drwxrwxr-x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duhow duhow duhow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom output file

3 participants

@Fubukimaru @jksigtermans @duhow