Skip to content

Add Docker build#101

Merged
Fubukimaru merged 4 commits into
masterfrom
docker
Jan 8, 2022
Merged

Add Docker build#101
Fubukimaru merged 4 commits into
masterfrom
docker

Conversation

@duhow

@duhow duhow commented Jan 7, 2022

Copy link
Copy Markdown
Collaborator

Add a Dockerfile to build asMSX, and add a Github Actions Workflow to build upon master branch and git tags.

@duhow

duhow commented Jan 7, 2022

Copy link
Copy Markdown
Collaborator Author

This also allows to run as a GitHub Action:

- name: Run asMSX
  uses: docker://ghcr.io/fubukimaru/asmsx:master
  with:
    args: GAME.ASM

@duhow duhow requested a review from Fubukimaru January 7, 2022 18:26
@duhow duhow marked this pull request as ready for review January 7, 2022 18:26

@Fubukimaru Fubukimaru left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool :)

Also I didn't know that you could already use Ubuntu 22.04

@Fubukimaru Fubukimaru merged commit 133d203 into master Jan 8, 2022
@Fubukimaru

Copy link
Copy Markdown
Owner

@duhow, Could you add some documentation about github-actions/docker so that old guys like me are able to check everytime we forget?

I don't require full explaination, just a couple of paragraphs defining what everything does and some references if possible.

Thanks!

@duhow duhow deleted the docker branch January 8, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants